Skip to content

Move TS docker to node20 #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yuandrew wants to merge 1 commit into from
Closed

Move TS docker to node20 #661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dockerfiles/ts.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# The author (git blame to reveal) prefers some copying over templating the Dockerfiles.

# Build in a full featured container
FROM node:16 as build
FROM node:20 as build

# Install protobuf compiler
RUN apt-get update \
Expand Down Expand Up @@ -45,7 +45,7 @@ COPY ./${REPO_DIR_OR_PLACEHOLDER} ./${REPO_DIR_OR_PLACEHOLDER}
RUN CGO_ENABLED=0 ./temporal-features prepare --lang ts --dir prepared --version "$SDK_VERSION"

# Copy the CLI and prepared feature to a distroless "run" container
FROM gcr.io/distroless/nodejs:16
FROM gcr.io/distroless/nodejs20-debian11

COPY --from=build /app/temporal-features /app/temporal-features
COPY --from=build /app/features /app/features
Expand Down
Loading