Skip to content

PHP: fix a floating error in the worker_restart feature check #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roxblnfk merged 1 commit into from
Jan 2, 2025
Merged

PHP: fix a floating error in the worker_restart feature check #570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions features/update/worker_restart/feature.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
use Temporal\Activity\ActivityMethod;
use Temporal\Activity\ActivityOptions;
use Temporal\Client\WorkflowStubInterface;
use Temporal\Exception\Failure\ApplicationFailure;
use Temporal\Workflow;
use Temporal\Workflow\WorkflowInterface;
use Temporal\Workflow\WorkflowMethod;
Expand Down Expand Up @@ -58,9 +57,8 @@ public function blocks(): string
$this->kv->set(KV_ACTIVITY_STARTED, true);

do {
$blocked = $this->kv->get(KV_ACTIVITY_BLOCKED);
$blocked = $this->kv->get(KV_ACTIVITY_BLOCKED, true);

\is_bool($blocked) or throw new ApplicationFailure('KV BLOCKED key not set', 'KvNotSet', true);
if (!$blocked) {
break;
}
Expand All @@ -80,7 +78,6 @@ public static function check(
ContainerInterface $c,
Runner $runner,
): void {
$c->get(StorageInterface::class)->set(KV_ACTIVITY_BLOCKED, true);
$handle = $stub->startUpdate('do_activities');

# Wait for the activity to start.
Expand Down
Loading