Skip to content

Bump python 1.7.0 => 1.9.0 #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dandavison merged 3 commits into from
Jan 18, 2025
Merged

Bump python 1.7.0 => 1.9.0 #569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1fa363
Bump python 1.7.0 => 1.9.0
dandavison Dec 23, 2024
24ec56e
Ignore type errors
dandavison Jan 18, 2025
31ec868
Do not continue if state does not match expectation
dandavison Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions features/reset/reset_and_delete/feature.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,8 @@ func CheckResult(ctx context.Context, r *harness.Runner, run client.WorkflowRun)
if err != nil {
return err
}
r.Assert.Equal(1, len(resp.GetExecutions()))
r.Assert.Equal(enums.WORKFLOW_EXECUTION_STATUS_TERMINATED, resp.GetExecutions()[0].Status)
r.Require.Equal(1, len(resp.GetExecutions()))
r.Require.Equal(enums.WORKFLOW_EXECUTION_STATUS_TERMINATED, resp.GetExecutions()[0].Status)

return err
}
Expand Down
2 changes: 1 addition & 1 deletion features/update/client_interceptor/feature.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,5 +63,5 @@ async def start_workflow_update(
workflows=[Workflow],
check_result=check_result,
start=start,
additional_client_config=ClientConfig(interceptors=[MyClientInterceptor()]),
additional_client_config=ClientConfig(interceptors=[MyClientInterceptor()]), # type: ignore
)
2 changes: 1 addition & 1 deletion harness/python/feature.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def register_feature(
check_result: Optional[Callable[[Runner, WorkflowHandle], Awaitable[None]]] = None,
worker_config: WorkerConfig = WorkerConfig(),
data_converter: DataConverter = DataConverter.default,
additional_client_config: ClientConfig = ClientConfig(),
additional_client_config=ClientConfig(), # type: ignore
) -> None:
# No need to register in a sandbox
if workflow.unsafe.in_sandbox():
Expand Down
16 changes: 8 additions & 8 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ packages = [

[tool.poetry.dependencies]
python = "^3.8"
temporalio = "^1.7.0"
temporalio = "^1.9.0"

[tool.poetry.dev-dependencies]
mypy = "^0.961"
Expand Down
Loading