You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the Python sandbox documentation to clarify that the WARN_ON_DYNAMIC_IMPORT policy only emits warnings for dynamically imported modules that are NOT in the passthrough list. This reflects the bug fix in sdk-python PR #1222 where the warning logic was moved to only trigger for non-passthrough modules, reducing noise from legitimate passthrough modules.
Help us improve Promptless — If this suggestion missed the mark, please share quick feedback.
If you want Promptless to make further changes on this PR, feel free to leave a comment tagging Promptless (It won't show up in the user drop down but Promptless will get it!)
Promptless escalated the following message to you. If you respond, please remember to tag Promptless:
Hi @lennessyy! Thanks for catching that. I've updated the PR description to use the full URL (temporalio/sdk-python#1222) instead of just "PR #1222" to ensure it links to the correct repository. The fix should now be visible in the PR description.
Just a reminder: If you'd like me to act on any feedback you have via Github comments, just type @Promptless in your suggestion and I'll get right on it! (I won't show up in the user dropdown, but I'll process any request that has @Promptless in the comment body.)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lennessyy
deleted the
promptless/python-sandbox-dynamic-import-warning-fix
branch
Updates the Python sandbox documentation to clarify that the
WARN_ON_DYNAMIC_IMPORTpolicy only emits warnings for dynamically imported modules that are NOT in the passthrough list. This reflects the bug fix in sdk-python PR #1222 where the warning logic was moved to only trigger for non-passthrough modules, reducing noise from legitimate passthrough modules.Open this suggestion in the Promptless dashboard
Help us improve Promptless — If this suggestion missed the mark, please share quick feedback.
If you want Promptless to make further changes on this PR, feel free to leave a comment tagging Promptless (It won't show up in the user drop down but Promptless will get it!)