Revamp Java/PHP/TS Continue-as-New documentation #3606
Conversation
|
Marking as draft to update dotnet, previously thought we were blocked for dotnet docs, but I was mistaken. |
…entation into CaN-update-all-other-sdks
|
dotnet has been added, ready for review |
| Inside your Workflow, call the [`ContinueAsNew()`](https://typescript.temporal.io/api/classes/workflow.ContinueAsNew) function with the same type. | ||
| This stops the Workflow right away and starts a new one. | ||
|
|
||
| <div class="copycode-notice-container"> |
There was a problem hiding this comment.
One nit -- is this actually showing a ContineuAsNew() function being called? This looks like we're returning wf.continueAsNew instead of calling something. Language can sometimes get confusing here when porting between eg Go and TS, so I'm not sure if this is what happened. These are also very, very short code samples; if it were up to me I think they might be easier to read if they looked something like:
## Your other Workflow code
...
ContinueAsNew()
But I don't feel too strongly about that.
Anyway -- after clarifying this sample I think we're good to merge!
There was a problem hiding this comment.
Ahh good callout, the issue is actually that I linked the wrong continueAsNew method, pushed a fix
There was a problem hiding this comment.
As for the Your other Workflow code suggestion, I decided against it because this is linking directly to the typescript sample, they can click on the link to view the whole sample for how it fits into the workflow
What does this PR do?
Update language specific CaN docs, similar to #3579
Notes to reviewers
Docs should match Go and Python, just with the sample code and links specific to the language.