Skip to content

Comments

Bug fix: fix --log-level help rendering#951

Merged
dandavison merged 1 commit intotemporalio:mainfrom
dandavison:fix-log-level-help
Feb 24, 2026
Merged

Bug fix: fix --log-level help rendering#951
dandavison merged 1 commit intotemporalio:mainfrom
dandavison:fix-log-level-help

Conversation

@dandavison
Copy link
Contributor

What was changed

Remove backticks that were causing broken --help rendering:

Before
Note spurious presence of "server start-dev" and lack of expected "string"

$ temporal --help | rg -C1 -F -- '--log-level'
                Log format. Accepted values: text, json. (default "text")
      --log-level server start-dev
                Log level. Default is "info" for most commands and "warn"

After

$ ./temporal --help | rg -C1 -F -- '--log-level'
                Log format. Accepted values: text, json. (default "text")
      --log-level string
                Log level. Default is "info" for most commands and "warn"

Why?

Bug

pflag's UnquoteUsage() extracts the first backtick-delimited text from a
flag's usage string and displays it as the type name next to the flag.
The backticks around `server start-dev` caused the help to render as:

  --log-level server start-dev    Log level. ...

Replace with double quotes to match the surrounding style.
@dandavison dandavison requested review from a team as code owners February 24, 2026 03:30
@dandavison dandavison merged commit 42c4db7 into temporalio:main Feb 24, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants