Embed fallback tzdata #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
approved these changes
Jan 18, 2024
Member
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
Can you confirm that this fixes the issue we saw?
Member
|
I wouldn't go as far as requiring an automated test, just manual confirmation. |
Contributor
Author
I verified it by running the cli dev-server in an empty docker container so that it couldn't find a platform database. It failed without the embedded db and succeeded with. |
This was referenced Jan 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Embed time zone database in case platform database can't be found.
Why?
This ensures time zones are always available, even on Windows which does not supply a time zone database (at least in a format that Go understands).