Skip to content

Adding support for as-is for scheduled workflow id #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ast2023 merged 3 commits into from
Feb 22, 2024
Merged

Adding support for as-is for scheduled workflow id #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
564d079
Adding support for as-is for scheduled workflow id
ast2023 Feb 21, 2024
f89ca55
Applying code review comments.
ast2023 Feb 21, 2024
0a874b1
adding generated files which should be added by a workflow on CI server
ast2023 Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions openapi/openapiv2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6247,6 +6247,10 @@
"pauseOnFailure": {
"type": "boolean",
"description": "If true, and a workflow run fails or times out, turn on \"paused\".\nThis applies after retry policies: the full chain of retries must fail to\ntrigger a pause here."
},
"keepOriginalWorkflowId": {
"type": "boolean",
"description": "If true, and the action would start a workflow, a timestamp will not be\nappended to the scheduled workflow id."
}
}
},
Expand Down
5 changes: 5 additions & 0 deletions openapi/openapiv3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4397,6 +4397,11 @@ components:
If true, and a workflow run fails or times out, turn on "paused".
This applies after retry policies: the full chain of retries must fail to
trigger a pause here.
keepOriginalWorkflowId:
type: boolean
description: |-
If true, and the action would start a workflow, a timestamp will not be
appended to the scheduled workflow id.
ScheduleSpec:
type: object
properties:
Expand Down
4 changes: 4 additions & 0 deletions temporal/api/schedule/v1/message.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,10 @@ message SchedulePolicies {
// This applies after retry policies: the full chain of retries must fail to
// trigger a pause here.
bool pause_on_failure = 3;

// If true, and the action would start a workflow, a timestamp will not be
// appended to the scheduled workflow id.
bool keep_original_workflow_id = 4;
}

message ScheduleAction {
Expand Down