-
Notifications
You must be signed in to change notification settings - Fork 85
Add workflow_start_delay #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
0dcf6da
ecf2e1a
8b45d44
31fc140
faeffc2
b637e3d
5cb3b51
974c794
825a21f
97b58ca
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -180,6 +180,10 @@ message StartWorkflowExecutionRequest { | |
| // StartWorkflowExecution. | ||
| temporal.api.failure.v1.Failure continued_failure = 18; | ||
| temporal.api.common.v1.Payloads last_completion_result = 19; | ||
| // Time to wait before dispatching the first workflow task. Cannot be used with `cron_schedule`. | ||
| // If the workflow gets a signal before the delay, a workflow task will be dispatched and the rest | ||
| // of the delay will be ignored. | ||
| google.protobuf.Duration workflow_start_delay = 20 [(gogoproto.stdduration) = true]; | ||
| } | ||
|
|
||
| message StartWorkflowExecutionResponse { | ||
|
|
@@ -625,6 +629,12 @@ message SignalWithStartWorkflowExecutionRequest { | |
| temporal.api.common.v1.Memo memo = 17; | ||
| temporal.api.common.v1.SearchAttributes search_attributes = 18; | ||
| temporal.api.common.v1.Header header = 19; | ||
| // Time to wait before dispatching the first workflow task. Cannot be used with `cron_schedule`. | ||
| // Note that the signal will be delivered with the first workflow task. If the workflow gets | ||
| // another SignalWithStartWorkflow before the delay, a workflow task will be dispatched immediately | ||
| // and the rest of the delay period will be ignored, even if that request also had a delay. Signal | ||
| // via SignalWorkflowExecution will not unblock the workflow. | ||
| google.protobuf.Duration workflow_start_delay = 20 [(gogoproto.stdduration) = true]; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one doesn't actually make much sense to me. The point is to start a workflow and immediately send it a signal, which usually means that the caller wants it to handle the signal as soon as possible. We already have a bunch of inconsistent/buggy behavior around delayed workflow start + signals, so I'd rather just leave this out and make this impossible to specify.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Talked internally, this is fine, but please change the comment to include more details |
||
| } | ||
|
|
||
| message SignalWithStartWorkflowExecutionResponse { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.