Repository navigation
Pr/add ace - #167
Open
Roddie01 wants to merge 2 commits into
Open
Pr/add ace#167Roddie01 wants to merge 2 commits into
Roddie01 wants to merge 2 commits into
Conversation
Collaborator
|
Hi @Roddie01, exciting to see this! Thanks for flagging the spectral density question. I suggest once @gefux and I have had a chance to look over the code we might want to arrange a quick meeting to discuss this and anything else we might spot. Helpful to have the I remember one of the first questions was regarding PT format. It looks like you were able to resolve that quite easily with a converter function? We can discuss whether it makes sense for this to live in OQuPy or as an export function in ACE. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for implementing ACE into OQuPy, as agreed in #152. I still need to add documentation, but I ran tests, and they were all positive. The main feature is discretising the spectral density; we may need to discuss this, as it requires a user-input spectral density to allow thermalisation. In addition, it allows the user to choose how to discretise the spectral density. Currently, it's only fully set up to work with Bosonic environments with the aim of extending it further later on.
tox -e py36(to runpytest) the code tests.tox -e style(to runpylint) the code style tests./docs/pages/modules.rsthas been updated./docs/pages/api.rsthas been updated.