test(cache): skip redis cache tests when connection fails #1457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip Redis cache tests when connection is unavailable, following the same pattern used in other Redis tests.
Problem: The test suite was failing on the cache tests in my DDEV environment where Redis runs in a separate container (host: redis). Since no host is explicitly specified in the test configuration, the Redis client falls back to localhost, causing connection failures and a failing test.
This also means Redis tests cannot be executed by developers whose environments run Redis with non-default connection settings, but i don't think that's a big issue.
@innocenzi maybe you can take a look at this since you've done most work on the Redis related code.