-
-
Notifications
You must be signed in to change notification settings - Fork 124
feat(support): add json encode/decode to array and string utilities #1396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Perfect! One thing I wonder about is whether we can automatically determine mutability based on the class So ImmutableString > ImmutableArray, MutableArray > MutableString, etc. @innocenzi do we already have a detection method for this in place? I actually don't think we do? If we don't, then let's not overcomplicate this PR. I'd remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should have a mutable
option, we can always call toMutableArray
and toMutableString
on the returned instance
Also, how about dropping json from the method name? If not, I would prefer |
Let's
|
@brendt @innocenzi take a look 👀 |
Closes #1388