Skip to content

fix(vite): exclude .tempest from vite's file watcher #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2025

Conversation

ewingd
Copy link
Contributor

@ewingd ewingd commented Jul 8, 2025

When the .tempest directory is being watched by Vite for changes, any javascript fetch requests trigger Vite to automatically refresh the page.

This excludes .tempest/* from the file watcher to prevent page refreshes on session or cache updates.

@ewingd ewingd changed the title bug(vite): Exclude .tempest directory from Vite's file watcher fix(vite): exclude .tempest directory from vite's file watcher Jul 8, 2025
@brendt
Copy link
Member

brendt commented Jul 8, 2025

Don't worry about the failing tests, not your fault

@brendt brendt requested a review from innocenzi July 8, 2025 11:35
Copy link
Member

@innocenzi innocenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in the plugin itself, not in the published config 👍

@ewingd ewingd force-pushed the vite-configuration branch 2 times, most recently from 78a5051 to 53ea0d5 Compare July 9, 2025 10:52
@ewingd
Copy link
Contributor Author

ewingd commented Jul 9, 2025

Sorry about the noise as I work to get the PR cleaned up, it's my first time working on a Vite plugin.

@ewingd ewingd force-pushed the vite-configuration branch from 3809cfe to b681d3f Compare July 9, 2025 11:04
@ewingd ewingd requested a review from innocenzi July 15, 2025 10:32
@innocenzi innocenzi changed the title fix(vite): exclude .tempest directory from vite's file watcher fix(vite): exclude .tempest from vite's file watcher Jul 16, 2025
@innocenzi
Copy link
Member

Thank you!

@innocenzi innocenzi merged commit e1bdcf2 into tempestphp:main Jul 16, 2025
70 checks passed
@ewingd ewingd deleted the vite-configuration branch July 23, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants