fix: update theme toggling in the footer#61
Merged
innocenzi merged 1 commit intotempestphp:mainfrom Mar 17, 2025
sneycampos:main
Merged
fix: update theme toggling in the footer#61innocenzi merged 1 commit intotempestphp:mainfrom sneycampos:main
innocenzi merged 1 commit intotempestphp:mainfrom
sneycampos:main
Conversation
sneycampos
changed the title
sneycampos
changed the title
innocenzi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the currently implementation there's a bug (at least for me) in the toggle theme button in the footer.
When i open the site for the first time and it loads with my system's theme, so i click in the toggle theme button and nothing happens but the button state is changed, so i click again and it changes the website theme.
In this PR i'm using the
toggleDarkModefunction to change the themeScreen.Recording.2025-03-17.at.14.43.34.mp4