Skip to content

Conversation

@brendo
Copy link
Contributor

@brendo brendo commented Aug 23, 2017

No description provided.

@brendo brendo force-pushed the make-token-read-from-gitlabrc branch from 1128cd3 to 542ddeb Compare August 23, 2017 07:32
@brendo brendo requested a review from quangkhoa August 23, 2017 11:14
@brendo brendo force-pushed the make-token-read-from-gitlabrc branch from 542ddeb to 4aa9bef Compare August 24, 2017 00:31

```sh
$ setAllVars
No URL specified, using git remote `origin`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether the app should display the same message for URL, e.g. not token provided, using token found under .gitlabrc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

README.md Outdated
If `--token` is not specified, this project can use a `.gitlabrc`, e.g:

```ini
token: this-is-my-gitlab-token
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be = instead of :

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@quangkhoa quangkhoa merged commit 383841d into temando:master Aug 24, 2017
@brendo brendo deleted the make-token-read-from-gitlabrc branch August 24, 2017 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants