Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MethodNotFoundException fixed #6

Merged
merged 2 commits into from
Dec 30, 2014
Merged

MethodNotFoundException fixed #6

merged 2 commits into from
Dec 30, 2014

Conversation

ozodrukh
Copy link
Contributor

No description provided.

@eveliotc
Copy link
Contributor

Can you please give us any details on the exception? e.g. stack-trace, android version, etc.

@ozodrukh
Copy link
Contributor Author

oh yes, i got MethodNotFoundException on Android Lollipop if use only inflateCompatOnly(), and i think it's not related to android 2.3 support

@eveliotc
Copy link
Contributor

Heheh that method is not supposed to be used for 21+, use
MrVector.inflate instead, will add an exception to state so, however like
the idea of using a reflection cache, will review later today :)

On Sun, Dec 28, 2014, 14:27 Ozodrukh notifications@github.com wrote:

oh yes, i got MethodNotFoundException on Android Lollipop if use only
inflateCompatOnly()

—
Reply to this email directly or view it on GitHub
#6 (comment).

@ozodrukh
Copy link
Contributor Author

Furthermore with this fix your VectorDrawable#setTint works :)

eveliotc
eveliotc reviewed Dec 29, 2014
View reviewed changes
library/src/main/java/com/telly/mrvector/Utils.java

return tryInvoke(target, methodName, argTypes, args);
}
static Map<String, Method> sCachedMethods = new HashMap<>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use SimpleArrayMap

@eveliotc
Copy link
Contributor

@ozodrukh let me know if you don't mind making those changes and then squashing commits, otherwise I can apply them myself

@ozodrukh
Copy link
Contributor Author

@eveliotc, Thanks for notice, done :)

eveliotc added a commit that referenced this pull request Dec 30, 2014
@eveliotc
Merge pull request #6 from ozodrukh/patch-1
df4c821 
- setTint reportedly working
- Allow reflection method caching
- Fixes MethodNotFoundException on Lollipop
@eveliotc eveliotc merged commit df4c821 into telly:master Dec 30, 2014
@eveliotc
Copy link
Contributor

Thanks @ozodrukh will deploy to maven central first thing tomorrow morning as long with 7+ minSdk

@ozodrukh
Copy link
Contributor Author

@eveliotc, Are you tested under minSdk 7+ ? I'm sure in gingerbread with 9+

@eveliotc
Copy link
Contributor

I just want to match appcompat, will test on 7+ ;)

On Mon, Dec 29, 2014, 22:58 Ozodrukh notifications@github.com wrote:

@eveliotc https://github.com/eveliotc, Are you tested under minSdk 7+ ?
I'm sure in gingerbread with 9+

—
Reply to this email directly or view it on GitHub
#6 (comment).

@ozodrukh
Copy link
Contributor Author

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ozodrukh @eveliotc