-
Notifications
You must be signed in to change notification settings - Fork 8
Add PR Body to metadata #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please let me know if you want me to make storing this particular metadata as optional - e.g. it can be as a bool param in the |
|
Hi @itsdalmo - Can you please look into the issue why the CI build seems to be failing? I wasn't able to figure it out - from what I saw it looks like all the tests are passing, so I wasn't sure if It was anything I changed 😖 I also double checked that I indented all the lines with tabs this time, if it helps 😅 Here's the sample log output I saw (wasn't able to figure out what the issue was): Would appreicate if you could look into this -- Thanks! |
|
completely confused as to why the CI build suddenly started passing 😕 I didn't make any noticeable changes since the last edit. I thought there was a newline missing in the for some reason that alone seemed to fix the CI build - really not sure how, haha. Just glad that its working fine now though. |
|
Hi @rnag and thanks for the PR! Unfortunately I think this could have adverse effects that outweigh the benefits for most people (web view cluttered with the PR body, and also has the potential to put extra strain on Concourse). As such I don't think this feature belongs upstream, but can perhaps be used via your fork? Thanks! |
Referenced https://developer.github.com/v4/object/pullrequest/
Referenced #158 so I could figure out where I need to add the changes (Thanks! I'm still a newbie in Go 😄 )
This can be useful for performing some validations on the contents of the PR body.