This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Use profileDir from settingsService #1023
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently CLI's configuration directory is used from
$options.profileDir. When user passes--profileDir <path>, the$options.profileDirvalue is populated.In case user does not pass anything, a default value is set. All services that require configuration directory use the
$options.profileDir. However, this causes several issues:$optionsis intended for use only when CLI is used as a standalone command line. In case you are using it as a library, the$optionsobject will not be populated.In order to resolve these issues, move the logic for profileDir in
settingsServiceand introduce a new method to get the profileDir. In order to ensure code is backwards compatible (i.e. extensions that use$options.profileDirshould still work), modify$optionsto set the value ofprofileDirinsettingsService.Whenever you want to test local extensions you can use:
Replace all places where
$options.profileDiris used with$settingsService.getProfileDir().