Fix misleading modal/non-modal description and typo in Popup overview#1409
Open
kalin-todorov wants to merge 1 commit into
Open
Fix misleading modal/non-modal description and typo in Popup overview#1409kalin-todorov wants to merge 1 commit into
kalin-todorov wants to merge 1 commit into
Conversation
The previous wording stated the UI gets inactive for both modal and non-modal popups, which is incorrect. Non-modal popups close on outside tap and do not block interaction with the underlying UI. Also fix typo: '.NE MAUI' -> '.NET MAUI' in the Next Steps link. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Telerik UI for .NET MAUI Popup overview documentation to correct misleading wording about modal vs non-modal behavior and fixes a typo in the “Next Steps” link text.
Changes:
- Reword the “Modal popups” bullet to better distinguish modal vs non-modal behavior.
- Fix a typo in the “Getting Started” link text (”.NE MAUI” → “.NET MAUI”).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## Key Features of the .NET MAUI Popup | ||
|
|
||
| * [Modal popups]({% slug popup-modal %})—You can define whether the popup will be modal or not. In both cases, the UI behind the MAUI popup gets inactive and cannot be used until the popup is closed. When you have a modal popup, it will not be automatically closed when the user clicks outside its viewport. | ||
| * [Modal popups]({% slug popup-modal %})—You can define whether the popup will be modal or not. For modal popups, the UI behind is inactive and cannot be used until the popup is closed, and tapping outside does not dismiss it. For non-modal popups, tapping outside the popup closes it automatically. |
| ## Key Features of the .NET MAUI Popup | ||
|
|
||
| * [Modal popups]({% slug popup-modal %})—You can define whether the popup will be modal or not. In both cases, the UI behind the MAUI popup gets inactive and cannot be used until the popup is closed. When you have a modal popup, it will not be automatically closed when the user clicks outside its viewport. | ||
| * [Modal popups]({% slug popup-modal %})—You can define whether the popup will be modal or not. For modal popups, the UI behind is inactive and cannot be used until the popup is closed, and tapping outside does not dismiss it. For non-modal popups, tapping outside the popup closes it automatically. |
| ## Key Features of the .NET MAUI Popup | ||
|
|
||
| * [Modal popups]({% slug popup-modal %})—You can define whether the popup will be modal or not. In both cases, the UI behind the MAUI popup gets inactive and cannot be used until the popup is closed. When you have a modal popup, it will not be automatically closed when the user clicks outside its viewport. | ||
| * [Modal popups]({% slug popup-modal %})—You can define whether the popup will be modal or not. For modal popups, the UI behind is inactive and cannot be used until the popup is closed, and tapping outside does not dismiss it. For non-modal popups, tapping outside the popup closes it automatically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two issues in controls/popup/overview.md:
The modal popups bullet incorrectly stated that in both modal and non-modal cases the UI behind gets inactive. Non-modal popups do not block interaction -- they simply close when the user taps outside. The modal-popup.md article already has the correct distinction, but the overview was misleading.
Typo in the Next Steps link: '.NE MAUI' -> '.NET MAUI'
Changes