Feature/#44 rethink logic for mapping children #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… structure added referenceType 'children' to support composition between mapping structure and uidl structure BREAKING CHANGE: old UIDLs don't work with the new structure resolve #44
Codecov Report
@@ Coverage Diff @@
## release/0.6 #149 +/- ##
===============================================
- Coverage 89.32% 89.15% -0.17%
===============================================
Files 51 52 +1
Lines 1752 1780 +28
Branches 203 203
===============================================
+ Hits 1565 1587 +22
- Misses 167 173 +6
Partials 20 20
Continue to review full report at Codecov.
|
vladnicula
approved these changes
Apr 5, 2019
alexnm
added a commit
that referenced
this pull request
Apr 8, 2019
* refactor(Support json attributes): Handle json attributes form uidl component files No UIDL schmea update. Adds handling for new schema definition for attributes from #35#issuecomment-477526242 BREAKING CHANGE: After this change, assigning string values on attributes will throw error. Use the new json structure instead. re #35, re #87, re #105 * Add repeat test and update structrue * Temp commit * Patch up attempt to support string in attribute * Tests pass after merge with master * refactor(attrs): dynamic and static nodes for all ocurrences of $ str… (#120) * refactor(attrs): dynamic and static nodes for all ocurrences of $ strings only text nodes are left with the old implementation, but they require more changes in the UIDL structure. Repeats are now working as expected with both dynamic and static attributes as the datasource BREAKING CHANGE: old UIDLs don't work anymore #35 * refactor(mapping): new UIDL attribute structure used to replace $attrs. reference BREAKING CHANGE: Old mappings do not work anymore #35 * refactor(dataSource): Switch statement for selecting the right identifier * Refactor/#117 style props uidl (#127) * Attrs update for main exmaple uidls * Functional basic styles in react component generators * Add nested style tests. Failing vue, working react * Typo fixes * Passing tests for vue generaorts wiht new style definitions * All tests passing for new style definitions * Hacky fix for static content not supportive of arrays * WIP: Feature/#112 object referinging in dynamic assignments (#131) * Add back commented tests * Vue generators support for object props * Feature/#118 udil string to json props (#130) * Style object utils for mixed uidl values * Attributes mapping to new json values * Feature/#112 object referinging in dynamic assignments (#132) * Add back commented tests * Vue generators support for object props * Fix styledjsx incorect props assignment * Refactor/#105 component structure changes (#134) * refactor(UIDL Structure): Differentiate between Node and Element BREAKING CHANGE: UIDLs need to be written in the new form #105 * refactor(UIDL Structure): Mapping and Repeat BREAKING CHANGE: Old UIDLs and Mappings don't work anymore #105 * refactor(UIDL Structure): Conditional rendering nodes in the UIDL BREAKING CHANGE: New way of describing states #closes 105 * refactor(UIDL Structure): Routing implemented based on the new UIDL nodes BREAKING CHANGE: Old UIDLs not working anymore #105 * refactor(UIDL Structure): Routing for all project-generators #105 * refactor(UIDL Structure): improve tests * test(UIDL Structure): All tests running except for validators #105 * Refactor/minor cleanup in 0.6 (#138) * refactor(Switch statement in react node generation): Add switch statement for node type Changes react node generation to use a switch which returns a proper value, no longer :any. * refactor(Switch statement in vue component generation): Add switch statement for node type * refactor(Common types for generator functions): Adds common types for the generateNodeSyntax function and addAttribute functions. Opens up the way to standardizing the entire component generation process. * Remove accumulators in switch statements * Fixes/release 0.6 (#142) * refactor(Switch statement in react node generation): Add switch statement for node type Changes react node generation to use a switch which returns a proper value, no longer :any. * refactor(Switch statement in vue component generation): Add switch statement for node type * refactor(Common types for generator functions): Adds common types for the generateNodeSyntax function and addAttribute functions. Opens up the way to standardizing the entire component generation process. * Remove accumulators in switch statements * Make sure import statements are added in the new uidl for project examples * feat(React Conditional Stmt Improvements): Better boolean checks Transforms conditionalVariable === true to conditionalVariable and condVar === false to !condVar fix #139 * Rename stateIdentifier back to normal * Refactor(component-generators): Refactored component generators inter… (#137) * refactor(component-generators): Refactored component generators interface to expose an array of file re #27 * refactor(component-generators): Fixed vue page file name. Refactored project-utils re #27 * refactor(component-generator): Renamed extension to fileType and removed the dot re #27 * refactor(component-generators): Fixed example file to have running generators * refactor(component-generators): Updated UIDL smaple to include style info re #27 * refactor(component-generators): Fixed component and style tests re #123 * refactor(component-generators): Updated all tests to new stucture fix #27 * feat(conditional render): support props as conditional identifier (#144) until now only state was allowed closes #75 * Fix for #148 (#150) * Fix for #148 * Log the entrie stack for errors * Remove commented out code for dynamic props * Same treatment for dynamics in both reapet and children * Member expression to jsx expression container * feat(uidl-schema): uidl-schema-update (#143) * feat(uidl-schema): adding partial uidl-schema * feat(new uidl schema): adding uidl schema new uidl schema. deleting old one. fix on tests. decommenting tests. * feat(mapping): children placeholder implementation with new UIDL node structure (#149) added referenceType 'children' to support composition between mapping structure and uidl structure BREAKING CHANGE: old UIDLs don't work with the new structure resolve #44 * chore(tests): remove console.log * chore: typings for new file * refactor(Better project error): Full stack trace log (#162) When a component fails to render I'd like to know where the error happened and why. Simply wwarning the error is not enough * Feature/#118 uidl transform in pipeline (#155) * Flow is ready for parsing string value of uidl * Parser passing tests expect for old children * Fix failing tests due to missing interface imports * Children parsing according to current 0.6 spec * Remove useless test * Support repeater and conditional in string to object parsing * Pass noClone in component parser when running from project #155 * feat(slots): support for React children and Vue <slot> (#158) * feat(slots): support for React children and Vue <slot> closes #156 * feat(slots): Support for traversing through slot nodes closes #156 * chore: typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #44