Skip to content

Page or component style page-name should be different from global-styles #623

Open
@JayaKrishnaNamburu

Description

@JayaKrishnaNamburu

Change the global-stylesheet name to global-style across all flavours. In certain flavours we are having the name of pages and global styles as same. This is creating a clash for the imports. Here is a example to reproduce it
https://codesandbox.io/s/d039b?file=/src/routes/home/index.js

Since we save the dependencies from plugins using a Record<string, UIDLDependency>. When the file names are same and still paths are different, while saving with the DS we do using file name alone and not path. So the dependencies are joining even paths are different.

Expected

import projectStyles from '../../style.css'
import styles from './style.css'

Current behaviour

import projectStyles, { styles } from './style.css'

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions