ci: update workflows on release/25.10-lts #197
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
9 issues found across 12 files
Confidence score: 2/5
- Multiple workflow env var renames conflict with existing scripts (
update-version.sh,setup-code.sh, Dockerfile), so version inputs are ignored or steps will fail; this is likely to break CI/package builds. - Container and k8s integration tests will likely fail because workflows now set TELEMETRY_* vars while scripts still require FLUENTDO_* vars, leading to unset variable exits or testing against missing binaries.
- Severity is medium-high (6–7/10) across several workflows, indicating concrete CI regressions rather than minor cleanup.
- Pay close attention to
.github/workflows/update-version.yaml,.github/workflows/call-build-linux-packages.yaml,.github/workflows/pr-comment-build.yaml,.github/workflows/call-test-packages.yaml,.github/workflows/call-test-containers.yaml,.github/workflows/call-test-containers-k8s.yaml,.github/workflows/call-build-containers.yaml- env var name mismatches causing ignored versions or failing scripts/tests.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name=".github/workflows/update-version.yaml">
<violation number="1" location=".github/workflows/update-version.yaml:137">
P1: The workflow now sets `NEW_TELEMETRY_FORGE_AGENT_VERSION`, but update-version.sh requires `NEW_FLUENTDO_AGENT_VERSION` and exits if it’s missing. This will cause the update step to fail. Use the variable name expected by the script (or update the script accordingly).</violation>
</file>
<file name=".github/workflows/pr-comment-build.yaml">
<violation number="1" location=".github/workflows/pr-comment-build.yaml:118">
P2: The workflow now greps for `TELEMETRY_FORGE_AGENT_VERSION`, but `Dockerfile.ubi` only defines `FLUENTDO_AGENT_VERSION`. This will set `VERSION` to empty and break downstream build metadata.</violation>
</file>
<file name=".github/workflows/call-test-packages.yaml">
<violation number="1" location=".github/workflows/call-test-packages.yaml:178">
P2: The integration test matrix now points to /opt/telemetryforge-agent, but the packages and test scripts still install/expect /opt/fluentdo-agent. This will make the workflow run tests against a non-existent binary and fail.</violation>
</file>
<file name=".github/workflows/call-test-containers.yaml">
<violation number="1" location=".github/workflows/call-test-containers.yaml:52">
P2: The integration test script still requires `FLUENTDO_AGENT_TAG`, but the workflow now only exports `TELEMETRY_FORGE_AGENT_TAG`, so `run-container-integration-tests.sh` will exit with an unset variable error. Export the legacy variable (or update the script) to keep tests working.</violation>
<violation number="2" location=".github/workflows/call-test-containers.yaml:94">
P2: `run-container-integration-tests.sh` requires `FLUENTDO_AGENT_IMAGE`, but the workflow now only sets `TELEMETRY_FORGE_AGENT_IMAGE`, so the script will fail due to an unset variable. Provide the legacy variable (or update the script) so the tests receive the image name.</violation>
</file>
<file name=".github/workflows/call-test-containers-k8s.yaml">
<violation number="1" location=".github/workflows/call-test-containers-k8s.yaml:32">
P2: The workflow now sets TELEMETRY_FORGE_AGENT_IMAGE/TELEMETRY_FORGE_AGENT_TAG, but the k8s integration tests still read FLUENTDO_AGENT_IMAGE/FLUENTDO_AGENT_TAG. As a result, the tests will ignore the input image/tag and run against the default image/tag. Set the legacy variables (or update the scripts) to keep the test image consistent with inputs.</violation>
</file>
<file name=".github/workflows/call-build-linux-packages.yaml">
<violation number="1" location=".github/workflows/call-build-linux-packages.yaml:77">
P1: This renames the version env var, but scripts/setup-code.sh only reads FLUENTDO_AGENT_VERSION. The workflow will ignore inputs.version and use the default 25.10.16, producing packages for the wrong version.</violation>
</file>
<file name=".github/workflows/call-build-containers.yaml">
<violation number="1" location=".github/workflows/call-build-containers.yaml:87">
P2: `setup-code.sh` only consumes `FLUENTDO_AGENT_VERSION`, so renaming the env var here prevents the requested version from being applied and causes the script to fall back to its default. Use the existing `FLUENTDO_AGENT_VERSION` name so the version input is honored.</violation>
<violation number="2" location=".github/workflows/call-build-containers.yaml:146">
P2: The test image build-arg name no longer matches the Dockerfile (`FLUENTDO_AGENT_VERSION`), so the input version is ignored during the test image build. Use the existing build-arg name.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| shell: bash | ||
| env: | ||
| NEW_FLUENTDO_AGENT_VERSION: ${{ steps.get-version.outputs.next_tag }} | ||
| NEW_TELEMETRY_FORGE_AGENT_VERSION: ${{ steps.get-version.outputs.next_tag }} |
There was a problem hiding this comment.
P1: The workflow now sets NEW_TELEMETRY_FORGE_AGENT_VERSION, but update-version.sh requires NEW_FLUENTDO_AGENT_VERSION and exits if it’s missing. This will cause the update step to fail. Use the variable name expected by the script (or update the script accordingly).
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/update-version.yaml, line 137:
<comment>The workflow now sets `NEW_TELEMETRY_FORGE_AGENT_VERSION`, but update-version.sh requires `NEW_FLUENTDO_AGENT_VERSION` and exits if it’s missing. This will cause the update step to fail. Use the variable name expected by the script (or update the script accordingly).</comment>
<file context>
@@ -134,7 +134,7 @@ jobs:
shell: bash
env:
- NEW_FLUENTDO_AGENT_VERSION: ${{ steps.get-version.outputs.next_tag }}
+ NEW_TELEMETRY_FORGE_AGENT_VERSION: ${{ steps.get-version.outputs.next_tag }}
- name: Debug
</file context>
Suggested change
| NEW_TELEMETRY_FORGE_AGENT_VERSION: ${{ steps.get-version.outputs.next_tag }} | |
| NEW_FLUENTDO_AGENT_VERSION: ${{ steps.get-version.outputs.next_tag }} |
| shell: bash | ||
| env: | ||
| FLUENTDO_AGENT_VERSION: ${{ inputs.version }} | ||
| TELEMETRY_FORGE_AGENT_VERSION: ${{ inputs.version }} |
There was a problem hiding this comment.
P1: This renames the version env var, but scripts/setup-code.sh only reads FLUENTDO_AGENT_VERSION. The workflow will ignore inputs.version and use the default 25.10.16, producing packages for the wrong version.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/call-build-linux-packages.yaml, line 77:
<comment>This renames the version env var, but scripts/setup-code.sh only reads FLUENTDO_AGENT_VERSION. The workflow will ignore inputs.version and use the default 25.10.16, producing packages for the wrong version.</comment>
<file context>
@@ -74,7 +74,7 @@ jobs:
shell: bash
env:
- FLUENTDO_AGENT_VERSION: ${{ inputs.version }}
+ TELEMETRY_FORGE_AGENT_VERSION: ${{ inputs.version }}
- name: Deltas
</file context>
Suggested change
| TELEMETRY_FORGE_AGENT_VERSION: ${{ inputs.version }} | |
| FLUENTDO_AGENT_VERSION: ${{ inputs.version }} |
| run: | | ||
| set -euo pipefail | ||
| VERSION=$(grep "ARG FLUENTDO_AGENT_VERSION=" Dockerfile.ubi | cut -d '=' -s -f 2 -) | ||
| VERSION=$(grep "ARG TELEMETRY_FORGE_AGENT_VERSION=" Dockerfile.ubi | cut -d '=' -s -f 2 -) |
There was a problem hiding this comment.
P2: The workflow now greps for TELEMETRY_FORGE_AGENT_VERSION, but Dockerfile.ubi only defines FLUENTDO_AGENT_VERSION. This will set VERSION to empty and break downstream build metadata.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/pr-comment-build.yaml, line 118:
<comment>The workflow now greps for `TELEMETRY_FORGE_AGENT_VERSION`, but `Dockerfile.ubi` only defines `FLUENTDO_AGENT_VERSION`. This will set `VERSION` to empty and break downstream build metadata.</comment>
<file context>
@@ -115,7 +115,7 @@ jobs:
run: |
set -euo pipefail
- VERSION=$(grep "ARG FLUENTDO_AGENT_VERSION=" Dockerfile.ubi | cut -d '=' -s -f 2 -)
+ VERSION=$(grep "ARG TELEMETRY_FORGE_AGENT_VERSION=" Dockerfile.ubi | cut -d '=' -s -f 2 -)
echo "Using version: $VERSION"
echo "version=$VERSION" >> $GITHUB_OUTPUT
</file context>
Suggested change
| VERSION=$(grep "ARG TELEMETRY_FORGE_AGENT_VERSION=" Dockerfile.ubi | cut -d '=' -s -f 2 -) | |
| VERSION=$(grep "ARG FLUENTDO_AGENT_VERSION=" Dockerfile.ubi | cut -d '=' -s -f 2 -) |
| package: package-ubuntu-24.04 | ||
| name: ubuntu | ||
| binary: /opt/fluentdo-agent/bin/fluent-bit | ||
| binary: /opt/telemetryforge-agent/bin/fluent-bit |
There was a problem hiding this comment.
P2: The integration test matrix now points to /opt/telemetryforge-agent, but the packages and test scripts still install/expect /opt/fluentdo-agent. This will make the workflow run tests against a non-existent binary and fail.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/call-test-packages.yaml, line 178:
<comment>The integration test matrix now points to /opt/telemetryforge-agent, but the packages and test scripts still install/expect /opt/fluentdo-agent. This will make the workflow run tests against a non-existent binary and fail.</comment>
<file context>
@@ -175,7 +175,7 @@ jobs:
package: package-ubuntu-24.04
name: ubuntu
- binary: /opt/fluentdo-agent/bin/fluent-bit
+ binary: /opt/telemetryforge-agent/bin/fluent-bit
# - runner: windows-latest
# package-type: msi
</file context>
| env: | ||
| # We use the actual image here for testing against | ||
| FLUENTDO_AGENT_IMAGE: ${{ inputs.image }} | ||
| TELEMETRY_FORGE_AGENT_IMAGE: ${{ inputs.image }} |
There was a problem hiding this comment.
P2: run-container-integration-tests.sh requires FLUENTDO_AGENT_IMAGE, but the workflow now only sets TELEMETRY_FORGE_AGENT_IMAGE, so the script will fail due to an unset variable. Provide the legacy variable (or update the script) so the tests receive the image name.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/call-test-containers.yaml, line 94:
<comment>`run-container-integration-tests.sh` requires `FLUENTDO_AGENT_IMAGE`, but the workflow now only sets `TELEMETRY_FORGE_AGENT_IMAGE`, so the script will fail due to an unset variable. Provide the legacy variable (or update the script) so the tests receive the image name.</comment>
<file context>
@@ -91,7 +91,7 @@ jobs:
env:
# We use the actual image here for testing against
- FLUENTDO_AGENT_IMAGE: ${{ inputs.image }}
+ TELEMETRY_FORGE_AGENT_IMAGE: ${{ inputs.image }}
# allow for some parallelity without GNU parallel, since it is not installed by default
BATS_NO_PARALLELIZE_ACROSS_FILES: 1
</file context>
Suggested change
| TELEMETRY_FORGE_AGENT_IMAGE: ${{ inputs.image }} | |
| FLUENTDO_AGENT_IMAGE: ${{ inputs.image }} | |
| TELEMETRY_FORGE_AGENT_IMAGE: ${{ inputs.image }} |
| runs-on: ubuntu-latest | ||
| env: | ||
| FLUENTDO_AGENT_TAG: ${{ inputs.image-tag }} | ||
| TELEMETRY_FORGE_AGENT_TAG: ${{ inputs.image-tag }} |
There was a problem hiding this comment.
P2: The integration test script still requires FLUENTDO_AGENT_TAG, but the workflow now only exports TELEMETRY_FORGE_AGENT_TAG, so run-container-integration-tests.sh will exit with an unset variable error. Export the legacy variable (or update the script) to keep tests working.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/call-test-containers.yaml, line 52:
<comment>The integration test script still requires `FLUENTDO_AGENT_TAG`, but the workflow now only exports `TELEMETRY_FORGE_AGENT_TAG`, so `run-container-integration-tests.sh` will exit with an unset variable error. Export the legacy variable (or update the script) to keep tests working.</comment>
<file context>
@@ -49,7 +49,7 @@ jobs:
runs-on: ubuntu-latest
env:
- FLUENTDO_AGENT_TAG: ${{ inputs.image-tag }}
+ TELEMETRY_FORGE_AGENT_TAG: ${{ inputs.image-tag }}
permissions:
packages: read
</file context>
Suggested change
| TELEMETRY_FORGE_AGENT_TAG: ${{ inputs.image-tag }} | |
| FLUENTDO_AGENT_TAG: ${{ inputs.image-tag }} | |
| TELEMETRY_FORGE_AGENT_TAG: ${{ inputs.image-tag }} |
| env: | ||
| FLUENTDO_AGENT_IMAGE: ${{ inputs.image }} | ||
| FLUENTDO_AGENT_TAG: ${{ inputs.image-tag }} | ||
| TELEMETRY_FORGE_AGENT_IMAGE: ${{ inputs.image }} |
There was a problem hiding this comment.
P2: The workflow now sets TELEMETRY_FORGE_AGENT_IMAGE/TELEMETRY_FORGE_AGENT_TAG, but the k8s integration tests still read FLUENTDO_AGENT_IMAGE/FLUENTDO_AGENT_TAG. As a result, the tests will ignore the input image/tag and run against the default image/tag. Set the legacy variables (or update the scripts) to keep the test image consistent with inputs.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/call-test-containers-k8s.yaml, line 32:
<comment>The workflow now sets TELEMETRY_FORGE_AGENT_IMAGE/TELEMETRY_FORGE_AGENT_TAG, but the k8s integration tests still read FLUENTDO_AGENT_IMAGE/FLUENTDO_AGENT_TAG. As a result, the tests will ignore the input image/tag and run against the default image/tag. Set the legacy variables (or update the scripts) to keep the test image consistent with inputs.</comment>
<file context>
@@ -29,8 +29,8 @@ jobs:
env:
- FLUENTDO_AGENT_IMAGE: ${{ inputs.image }}
- FLUENTDO_AGENT_TAG: ${{ inputs.image-tag }}
+ TELEMETRY_FORGE_AGENT_IMAGE: ${{ inputs.image }}
+ TELEMETRY_FORGE_AGENT_TAG: ${{ inputs.image-tag }}
KIND_VERSION: ${{ inputs.kind-version }}
</file context>
| labels: ${{ steps.meta.outputs.labels }} | ||
| build-args: | | ||
| FLUENTDO_AGENT_VERSION=${{ inputs.version }} | ||
| TELEMETRY_FORGE_AGENT_VERSION=${{ inputs.version }} |
There was a problem hiding this comment.
P2: The test image build-arg name no longer matches the Dockerfile (FLUENTDO_AGENT_VERSION), so the input version is ignored during the test image build. Use the existing build-arg name.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/call-build-containers.yaml, line 146:
<comment>The test image build-arg name no longer matches the Dockerfile (`FLUENTDO_AGENT_VERSION`), so the input version is ignored during the test image build. Use the existing build-arg name.</comment>
<file context>
@@ -143,7 +143,7 @@ jobs:
labels: ${{ steps.meta.outputs.labels }}
build-args: |
- FLUENTDO_AGENT_VERSION=${{ inputs.version }}
+ TELEMETRY_FORGE_AGENT_VERSION=${{ inputs.version }}
provenance: false
</file context>
Suggested change
| TELEMETRY_FORGE_AGENT_VERSION=${{ inputs.version }} | |
| FLUENTDO_AGENT_VERSION=${{ inputs.version }} |
| shell: bash | ||
| env: | ||
| FLUENTDO_AGENT_VERSION: ${{ inputs.version }} | ||
| TELEMETRY_FORGE_AGENT_VERSION: ${{ inputs.version }} |
There was a problem hiding this comment.
P2: setup-code.sh only consumes FLUENTDO_AGENT_VERSION, so renaming the env var here prevents the requested version from being applied and causes the script to fall back to its default. Use the existing FLUENTDO_AGENT_VERSION name so the version input is honored.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/call-build-containers.yaml, line 87:
<comment>`setup-code.sh` only consumes `FLUENTDO_AGENT_VERSION`, so renaming the env var here prevents the requested version from being applied and causes the script to fall back to its default. Use the existing `FLUENTDO_AGENT_VERSION` name so the version input is honored.</comment>
<file context>
@@ -84,7 +84,7 @@ jobs:
shell: bash
env:
- FLUENTDO_AGENT_VERSION: ${{ inputs.version }}
+ TELEMETRY_FORGE_AGENT_VERSION: ${{ inputs.version }}
- name: Deltas
</file context>
Suggested change
| TELEMETRY_FORGE_AGENT_VERSION: ${{ inputs.version }} | |
| FLUENTDO_AGENT_VERSION: ${{ inputs.version }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update workflows automatically on release/25.10-lts
Summary by cubic
Update GitHub Actions workflows to use telemetryforge-agent naming and env vars across builds, tests, and packaging on release/25.10-lts. Legacy GCS bucket paths remain for compatibility.
Written for commit c2fd55a. Summary will update on new commits.