-
Notifications
You must be signed in to change notification settings - Fork 1
ci: update workflows on release/25.10-lts #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update workflows on release/25.10-lts #189
Conversation
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> Signed-off-by: Pat <patrick.j.k.stephens@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 12 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name=".github/workflows/call-build-containers.yaml">
<violation number="1">
P1: Restore the `build-args: |` key so the test image build receives build arguments and the workflow remains valid YAML.</violation>
</file>
<file name=".github/workflows/call-build-macos-packages.yaml">
<violation number="1">
P2: The linkage check points to `bin/fluentdo-agent`, but the project’s executable is `fluent-bit`. This will make the linkage check fail and skip validation. Use the actual binary name to ensure the check runs.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| @@ -38,7 +38,7 @@ jobs: | |||
| uses: actions/checkout@v6 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: The linkage check points to bin/fluentdo-agent, but the project’s executable is fluent-bit. This will make the linkage check fail and skip validation. Use the actual binary name to ensure the check runs.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/call-build-macos-packages.yaml, line 96:
<comment>The linkage check points to `bin/fluentdo-agent`, but the project’s executable is `fluent-bit`. This will make the linkage check fail and skip validation. Use the actual binary name to ensure the check runs.</comment>
<file context>
@@ -93,13 +93,13 @@ jobs:
continue-on-error: true
run: |
- DYLD_PRINT_LIBRARIES=1 DYLD_PRINT_LIBRARIES_POST_LAUNCH=1 DYLD_PRINT_RPATHS=1 bin/telemetryforge-agent --dry-run
+ DYLD_PRINT_LIBRARIES=1 DYLD_PRINT_LIBRARIES_POST_LAUNCH=1 DYLD_PRINT_RPATHS=1 bin/fluentdo-agent --dry-run
working-directory: source/build
</file context>
| # We only build for amd64 as the test image is only used for running BATS tests | ||
| platforms: linux/amd64 | ||
| target: test | ||
| build-args: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cubic-dev-ai this change is incorrect so we should flag that next time
Signed-off-by: Patrick Stephens <pat@fluent.do>
Signed-off-by: Patrick Stephens <pat@fluent.do>
Signed-off-by: Patrick Stephens <pat@fluent.do>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="source/src/flb_record_dedup.c">
<violation number="1" location="source/src/flb_record_dedup.c:310">
P1: Rule violated: **Ensure tests are added**
Production code under `source/` was modified without any corresponding test changes under `source/tests/` or `source/testing/`, which violates the requirement to add/update automated tests for source changes (rule: Ensure tests are added).</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Update workflows automatically on release/25.10-lts
Summary by cubic
Rebranded CI workflows to Telemetry Forge on release/25.10-lts so builds, tests, and releases publish to the right registries and paths. Also disabled RocksDB ZSTD compression in record dedup to avoid issues on this LTS branch.
Refactors
Bug Fixes
Written for commit 8d92e7d. Summary will update on new commits.