fix: use sudo -n detection for all distros instead of hardcoding for Debian#1879
Open
badideasforsale wants to merge 1 commit into
Open
fix: use sudo -n detection for all distros instead of hardcoding for Debian#1879badideasforsale wants to merge 1 commit into
badideasforsale wants to merge 1 commit into
Conversation
Debian systems were unconditionally set to use --ask-become-pass, added to handle Debian 13's stricter default sudo configuration. This breaks Debian-based systems with passwordless sudo (e.g. DietPi), causing the installer to hang waiting for interactive input. The sudo -n true check already used for non-Debian systems handles both cases correctly: - Default Debian 13 (sudo requires password): exits 1 -> --ask-become-pass - Passwordless sudo (e.g. DietPi): exits 0 -> --become Remove the Debian special-case and apply the same detection universally.
badideasforsale
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debian systems were unconditionally set to use
--ask-become-pass, added to handle Debian 13's stricter default sudo configuration. This breaks Debian-based systems with passwordless sudo (e.g. DietPi), causing the installer to hang waiting for interactive input.The
sudo -n truecheck already used for non-Debian systems should handle both cases correctly:--ask-become-passsudo(e.g. DietPi): exits 0 →--becomeThis PR is a small change to remove the Debian special-case and apply the same detection universally.