Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Policy Error #1623

Closed
kanowah opened this issue Jul 23, 2024 Discussed in #1519 · 16 comments
Closed

Pull Policy Error #1623

kanowah opened this issue Jul 23, 2024 Discussed in #1519 · 16 comments
Labels
fix no basic support info Please follow the guidelines so we can help upstream-bug

Comments

@kanowah
Copy link

kanowah commented Jul 23, 2024

When I'm trying to install the new version, I'm getting the following error, I've tried to installed it on different devices still same:

Screenshot 2024-07-23 144016

@github-actions github-actions bot added the no basic support info Please follow the guidelines so we can help label Jul 23, 2024
@t3chn0m4g3 t3chn0m4g3 changed the title T-Pot 24.04.0 released 🎉 Pull Policy Error Jul 23, 2024
@t3chn0m4g3
Copy link
Member

Check the docker-compose.yml, it looks like you made changes around the map_web service and now T-Pot cannot start due to a missing setting.

@kanowah
Copy link
Author

kanowah commented Jul 23, 2024 via email

@kanowah
Copy link
Author

kanowah commented Jul 23, 2024

I've only used the following command:

env bash -c "$(curl -sL https://github.com/telekom-security/tpotce/raw/master/install.sh)"

@t3chn0m4g3
Copy link
Member

Then post the docker-compose.yml as formatted markdown because I cannot reproduce it and provide infos about your OS and such.

@akajhon
Copy link

akajhon commented Jul 23, 2024

Same problem here @kanowah and @t3chn0m4g3 !

When fresh installing via env bash -c "$(curl -sL https://github.com/telekom-security/tpotce/raw/master/install.sh)" using the default docker-compose.yml without changes, the message about the pull_policy is frequent.

Even when executing sudo systemctl start tpot the message for the pull_policy is raised and the docker containers do not start as usual.

I`ve been using an Ubuntu 22.04 live server.

@kanowah
Copy link
Author

kanowah commented Jul 23, 2024

I'm using the old TPot iso file from https://github.com/telekom-security/tpotce/releases/download/22.04.0/tpot_amd64.iso as it is light, the code is too long, here is a snippet of the docker-compose.yml, it's the default:

## Map Redis Service
  map_redis:
    container_name: map_redis
    restart: always
    depends_on:
      tpotinit:
        condition: service_healthy
    stop_signal: SIGKILL
    tty: true
    image: ${TPOT_REPO}/redis:${TPOT_VERSION}
    pull_policy: ${TPOT_PULL_POLICY}
    read_only: true

## Map Web Service
  map_web:
    container_name: map_web
    restart: always
    depends_on:
      tpotinit:
        condition: service_healthy
    environment:
     - MAP_COMMAND=AttackMapServer.py
    stop_signal: SIGKILL
    tty: true
    ports:
     - "127.0.0.1:64299:64299"
    image: ${TPOT_REPO}/map:${TPOT_VERSION}
    pull_policy: ${TPOT_PULL_POLICY}

## Map Data Service
  map_data:
    container_name: map_data
    restart: always
    depends_on:
      elasticsearch:
        condition: service_healthy
    environment:
     - MAP_COMMAND=DataServer_v2.py
     - TPOT_ATTACKMAP_TEXT=${TPOT_ATTACKMAP_TEXT}
     - TZ=${TPOT_ATTACKMAP_TEXT_TIMEZONE}
    stop_signal: SIGKILL
    tty: true
    image: ${TPOT_REPO}/map:${TPOT_VERSION}
    pull_policy: ${TPOT_PULL_POLICY}

@t3chn0m4g3
Copy link
Member

Thanks for the update, I can now reproduce it with a completely fresh install on Debian 12.
It looks like a new docker version is the culprit.

@mygitcrazy
Copy link

mygitcrazy commented Jul 23, 2024

I also spinned up a fresh installation a couple of days ago and it worked instantly. Today i installed the same installation again, and also getting the error as posted in this thread....

Ubuntu 24.04 and tried Debian 12 (same problem)

@t3chn0m4g3
Copy link
Member

t3chn0m4g3 commented Jul 23, 2024

A possible workaround...

Run sudo apt-cache madison docker-compose-plugin and it will spit out all the available repo versions:

docker-compose-plugin | 2.29.0-1~debian.12~bookworm | https://download.docker.com/linux/debian bookworm/stable arm64 Packages
docker-compose-plugin | 2.28.1-1~debian.12~bookworm | https://download.docker.com/linux/debian bookworm/stable arm64 Packages
[...]

We are only interested in the 2.28 branch and you can now install it with...
sudo apt-get install docker-compose-plugin=2.28.1-1~debian.12~bookworm

Then goto $HOME/tpotce and run docker compose pull and then sudo reboot.

Let me know if this works and I will update this for other OS installs if requested.

@mygitcrazy
Copy link

mygitcrazy commented Jul 23, 2024

Up and running 🎉
This (workaround) did work for me!!

Big thanks @t3chn0m4g3

@t3chn0m4g3
Copy link
Member

Thanks for the quick feedback @mygitcrazy! Happy it is working 🤩

@akajhon
Copy link

akajhon commented Jul 23, 2024

Works like a charm! Thanks for the fast help @t3chn0m4g3 !

@t3chn0m4g3
Copy link
Member

t3chn0m4g3 commented Jul 23, 2024

@akajhon Appreciate the fast response! Happy it is working for you, too! 🤩

@t3chn0m4g3
Copy link
Member

t3chn0m4g3 commented Jul 23, 2024

I will monitor this and as soon as Docker releases a fixed version I will update this issue accordingly.

Thanks @mygitcrazy @akajhon @kanowah for bringing this up and testing the workaround.

@t3chn0m4g3
Copy link
Member

t3chn0m4g3 commented Jul 23, 2024

The upstream issue has been closed and the fix is available in the 2.29.1 release. No details in the description, though and package not yet pushed to Docker Linux repositories.

@t3chn0m4g3 t3chn0m4g3 added the fix label Jul 24, 2024
@t3chn0m4g3
Copy link
Member

The new docker-compose-plugin was pushed to the Docker Linux repositories, just tested it and I can confirm this is resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix no basic support info Please follow the guidelines so we can help upstream-bug
Projects
None yet
Development

No branches or pull requests

4 participants