test(lib/string): Add test for makeName #22 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryshelomanov
changed the title
dmitryshelomanov
changed the title
syabro
reviewed
Nov 30, 2017
src/lib/string.test.js
Outdated
| first_name: faker.name.firstName(), | ||
| last_name: faker.name.lastName(), | ||
| } | ||
| const name = makeName(user) |
There was a problem hiding this comment.
Я бы переименовал в getUserFullname
There was a problem hiding this comment.
Да, так будет лучше. Но всё таки это лучше делать отдельным ПР
There was a problem hiding this comment.
@sergeysova да, конечно, просто обратил внимание
sergeysova
requested changes
Nov 30, 2017
src/lib/string.test.js
Outdated
| } | ||
| const name = makeName(user) | ||
|
|
||
| t.true(/[a-z]/ig.test(name)) |
There was a problem hiding this comment.
Нет. Тут должна быть проверка, что функция вернула не просто набор неких символов. А именно имя и фамилию.
src/lib/string.test.js
Outdated
| } | ||
| const name = makeName(user) | ||
|
|
||
| t.true(/[a-z]/ig.test(name)) |
There was a problem hiding this comment.
Как и здесь. Поможет метод t.is(a, b)
sergeysova
changed the title
|
Обосрали ( |
|
@userbq201 t.is(makeName(user), `${user.first_name} ${user.last_name}`)Это не очевидно разве? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Первый тест. Для makeName