Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flags to disable MQTT and AMQP #576

Merged
merged 7 commits into from
Nov 4, 2022

Conversation

jason-fox
Copy link
Contributor

This avoids unnecessary polling to connect to MQTT and AMQP if they are not there and keeps the logs nice and clean.
As a side-effect, startup is quicker too.

Just add the following config to your docker-compose.

      - IOTA_MQTT_DISABLED=true
      - IOTA_AMPQ_DISABLED=true

Evil twin of telefonicaid/iotagent-json#685

This avoids unnecessary polling to connect to MQTT and AMQP if they are not there and keeps the logs nice and clean.
As a side-effect, startup is quicker too.

Just add the following config to your docker-compose.

```
      - IOTA_MQTT_DISABLED=true
      - IOTA_AMPQ_DISABLED=true
```
@mapedraza
Copy link
Collaborator

Adding an entry into CHANGES_NEXT_RELEASE file is required before merging.

@jason-fox
Copy link
Contributor Author

Fixed 9432c29

CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
@@ -256,6 +256,7 @@ The ones relating specific Ultralight 2.0 bindings are described in the followin
| IOTA_MQTT_AVOID_LEADING_SLASH | mqtt.avoidLeadingSlash |
| IOTA_MQTT_CLEAN | mqtt.clean |
| IOTA_MQTT_CLIENT_ID | mqtt.clientId |
| IOTA_MQTT_DISABLED | mqtt.disabled |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config.js should be modified to include the new mqtt.disabled and amqp.disables settings (in commented way). Note config.js is used also somehow to document configurations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed bebba29

jason-fox and others added 2 commits November 4, 2022 09:38
Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 8f6429e into telefonicaid:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants