Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device and Group datamodels used in API requests differ from data models used internally or in MongoDB #1587

Open
AlvaroVega opened this issue Mar 4, 2024 · 5 comments
Labels

Comments

@AlvaroVega
Copy link
Member

AlvaroVega commented Mar 4, 2024

IoT Agent Node Lib version the issue has been seen with

1.X, 2.X, 3.X

Bound or port used (API interaction)

Other

NGSI version

NGSIv2

Are you running a container?

None

Image type

None

Expected behaviour you didn't see

I.E:

All datamodels used across codebase, API requests and DB models should be homogeneus

@AlvaroVega
Copy link
Member Author

We should review doc about ensure API s properly described.
Possibly a db script update should be needed to solve this issue if finally should be fixed.

@AlvaroVega AlvaroVega changed the title active attributes are stored in Device model as "active" bug as "attributes" in Group Model active attributes are stored in Device model as "active" but as "attributes" in Group Model Mar 12, 2024
@Madhu1029
Copy link
Contributor

Hi @AlvaroVega ,

Could you please explain this issue in detail? I want to work on this issue.

@AlvaroVega AlvaroVega changed the title active attributes are stored in Device model as "active" but as "attributes" in Group Model active attributes are stored in Device model (mongo) as "active" but are stored in Group Model as "attributes" May 14, 2024
@AlvaroVega
Copy link
Member Author

Hi @AlvaroVega ,

Could you please explain this issue in detail? I want to work on this issue.

Not sure if this is the best issue to implement now, since implements changes in database (mongo) model and has some impact in current production deploys.

@mapedraza mapedraza changed the title active attributes are stored in Device model (mongo) as "active" but are stored in Group Model as "attributes" Device and Group datamodels used in API requests differ from datamodels used in Mongo Aug 26, 2024
@mapedraza mapedraza changed the title Device and Group datamodels used in API requests differ from datamodels used in Mongo Device and Group datamodels used in API requests differ from data models used internally or in MongoDB Aug 26, 2024
@fgalan
Copy link
Member

fgalan commented Aug 26, 2024

As part of this issue, analyze which exact adaptations are needed.

The final objective is that API, code and DB model get aligned (code-API adaptation is also mentioned here).

@fgalan
Copy link
Member

fgalan commented Aug 26, 2024

Maybe both #1649 and this issue should be addressed together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants