Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REMOVE operations no longer supported by Orion in orionUrls.js #523

Merged
merged 7 commits into from
Jul 7, 2023
Merged

REMOVE operations no longer supported by Orion in orionUrls.js #523

merged 7 commits into from
Jul 7, 2023

Conversation

fgalan
Copy link
Member

@fgalan fgalan commented Jul 7, 2023

From https://github.com/telefonicaid/fiware-orion/releases/tag/3.10.0, the decrecated operations still supported are:

  • PUT /v1/contextEntities/{id}
  • DELETE /v1/contextEntities/{id}
  • GET /v1/contextEntities/{id}/attributes/{name}
  • POST /v1/updateContext
  • POST /NGSI10/updateContext
  • POST /v1/queryContext
  • POST /NGSI10/queryContext

@fgalan fgalan requested a review from AlvaroVega July 7, 2023 09:48
AlvaroVega
AlvaroVega approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@AlvaroVega AlvaroVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fgalan
fgalan commented Jul 7, 2023
View reviewed changes
test/unit/extract_csb_actions_test.js
@@ -255,67 +250,6 @@ describe('Extract Context Broker action from request', function() {

it('should add the action attribute with value "delete" to the request', testAction('delete', options));
});
describe('When a create action arrives with XML payload', function() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XML encoding was removed in Orion in March 2016! :O

NTC

@fgalan fgalan mentioned this pull request Jul 7, 2023
Open
AlvaroVega
AlvaroVega approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@AlvaroVega AlvaroVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlvaroVega AlvaroVega merged commit 24342eb into master Jul 7, 2023
@AlvaroVega AlvaroVega deleted the fgalan-patch-2 branch July 7, 2023 10:16
@fgalan fgalan mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlvaroVega AlvaroVega AlvaroVega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgalan @AlvaroVega