fix: Restore Appspace stops sandbox first

- fixes #131

cmd/ds-host/appspaceops/restoreappspace.go

@@ -35,6 +35,9 @@ type RestoreAppspace struct {
 		CheckDataFiles(dataDir string) error
 		ReplaceData(appspace domain.Appspace, source string) error
 	} `checkinject:"required"`
+	SandboxManager interface {
+		StopAppspace(domain.AppspaceID)
+	} `checkinject:"required"`
 	AppspaceStatus interface {
 		WaitTempPaused(appspaceID domain.AppspaceID, reason string) chan struct{}
 		IsTempPaused(appspaceID domain.AppspaceID) bool
@@ -188,6 +191,8 @@ func (r *RestoreAppspace) GetMetaInfo(tok string) (domain.AppspaceMetaInfo, erro
 
 // ReplaceData stops the appspace and replaces the data files
 func (r *RestoreAppspace) ReplaceData(tok string, appspaceID domain.AppspaceID) error {
+	r.SandboxManager.StopAppspace(appspaceID)
+
 	closedCh, ok := r.AppspaceStatus.LockClosed(appspaceID)
 	if !ok {
 		return errors.New("failed to get lock closed")

cmd/ds-host/appspaceops/restoreappspace_test.go

@@ -1,7 +1,6 @@
 package appspaceops
 
 import (
-	"io/ioutil"
 	"os"
 	"testing"
 	"time"
@@ -12,7 +11,7 @@ import (
 )
 
 func TestDelete(t *testing.T) {
-	dir, err := ioutil.TempDir("", "")
+	dir, err := os.MkdirTemp("", "")
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -53,6 +52,9 @@ func TestReplaceData(t *testing.T) {
 
 	closedChan := make(chan struct{})
 
+	sandboxManager := testmocks.NewMockSandboxManager(mockCtrl)
+	sandboxManager.EXPECT().StopAppspace(asID)
+
 	appspaceStatus := testmocks.NewMockAppspaceStatus(mockCtrl)
 	appspaceStatus.EXPECT().LockClosed(asID).Return(closedChan, true)
 
@@ -69,6 +71,7 @@ func TestReplaceData(t *testing.T) {
 	appspaceFilesModels.EXPECT().ReplaceData(appspace, tempDir).Return(nil)
 
 	r := &RestoreAppspace{
+		SandboxManager:     sandboxManager,
 		AppspaceStatus:     appspaceStatus,
 		AppspaceMetaDB:     appspaceMetaDB,
 		AppspaceLogger:     appspaceLogger,

cmd/ds-host/ds-host.go

@@ -272,6 +272,7 @@ func main() {
 		InfoModel:             appspaceInfoModel,
 		AppspaceModel:         appspaceModel,
 		AppspaceFilesModel:    appspaceFilesModel,
+		SandboxManager:        sandboxManager,
 		AppspaceStatus:        nil,
 		AppspaceMetaDB:        appspaceMetaDb,
 		AppspaceLogger:        appspaceLogger,