Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knative undefined: injection.Dynamic #1639

Closed
mike-sirs opened this issue Sep 11, 2023 · 8 comments
Closed

Knative undefined: injection.Dynamic #1639

mike-sirs opened this issue Sep 11, 2023 · 8 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mike-sirs
Copy link

Knative dropped dynamic wrapped client generation

closed issue #1628

@khrm the issues still persist, the PR you've mentioned removed Dynamic from eventlistenersink/main.go
while the problem is with
https://github.com/tektoncd/triggers/blob/cc1b7b73f165e9480f0cd92ac0b0f36e0f0be3e0/pkg/client/injection/client/client.go#L51C2-L51C64

/go/pkg/mod/github.com/tektoncd/triggers@v0.25.0/pkg/client/injection/client/client.go:51:12: undefined: injection.Dynamic

go.mod:
	github.com/tektoncd/pipeline v0.50.1
	github.com/tektoncd/triggers v0.25.0
        knative.dev/pkg v0.0.0-20230718152110-aef227e72ead

could someone look at this, please?

knative/pkg#2739

@mike-sirs mike-sirs added the kind/bug Categorizes issue or PR as related to a bug. label Sep 11, 2023
@khrm
Copy link
Contributor

khrm commented Sep 11, 2023

Sure, I would remove this.

@khrm
Copy link
Contributor

khrm commented Sep 11, 2023

/assign @khrm

@khrm
Copy link
Contributor

khrm commented Jan 24, 2024

@mike-sirs Can you pick this up?

@khrm khrm unassigned khrm Jan 24, 2024
@khrm
Copy link
Contributor

khrm commented Jan 24, 2024

/help-wanted

@mike-sirs
Copy link
Author

/assign @mike-sirs

@mike-sirs
Copy link
Author

@khrm #1687

@mike-sirs mike-sirs removed their assignment Feb 5, 2024
@khrm
Copy link
Contributor

khrm commented Mar 28, 2024

@mike-sirs This is done now. Should be part of the next release.

@khrm khrm closed this as completed May 10, 2024
@khrm
Copy link
Contributor

khrm commented May 10, 2024

I closed this as the issue should be resolved by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants