-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Knative undefined: injection.Dynamic #1639
Labels
kind/bug
Categorizes issue or PR as related to a bug.
Milestone
Comments
Sure, I would remove this. |
/assign @khrm |
@mike-sirs Can you pick this up? |
/help-wanted |
/assign @mike-sirs |
@mike-sirs This is done now. Should be part of the next release. |
I closed this as the issue should be resolved by now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Knative dropped dynamic wrapped client generation
closed issue #1628
@khrm the issues still persist, the PR you've mentioned removed
Dynamic
fromeventlistenersink/main.go
while the problem is with
https://github.com/tektoncd/triggers/blob/cc1b7b73f165e9480f0cd92ac0b0f36e0f0be3e0/pkg/client/injection/client/client.go#L51C2-L51C64
could someone look at this, please?
knative/pkg#2739
The text was updated successfully, but these errors were encountered: