Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knative undefined: injection.Dynamic #1628

Closed
mike-sirs opened this issue Aug 15, 2023 · 5 comments
Closed

Knative undefined: injection.Dynamic #1628

mike-sirs opened this issue Aug 15, 2023 · 5 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mike-sirs
Copy link

Knative dropped dynamic wrapped client generation

it results in a compile error
triggers@v0.24.1/pkg/client/injection/client/client.go:51:12: undefined: injection.Dynamic

Steps to Reproduce the Problem

update to knative.dev/pkg v0.0.0-20230815132840-4f651e092853

related issue

knative/pkg#2739

@mike-sirs mike-sirs added the kind/bug Categorizes issue or PR as related to a bug. label Aug 15, 2023
@khrm
Copy link
Contributor

khrm commented Aug 16, 2023

@mike-sirs Didn't we remove it here? c366270

@mike-serchenia
Copy link

Can someone make a new release with that fix?

@khrm
Copy link
Contributor

khrm commented Aug 16, 2023

We will do a v0.25 next week or the week after next.

@khrm
Copy link
Contributor

khrm commented Aug 16, 2023

/assign @savitaashture

@mike-sirs
Copy link
Author

@khrm the issues still persist, the PR you've mentioned removed Dynamic from eventlistenersink/main.go
while the problem is with
https://github.com/tektoncd/triggers/blob/cc1b7b73f165e9480f0cd92ac0b0f36e0f0be3e0/pkg/client/injection/client/client.go#L51C2-L51C64

/go/pkg/mod/github.com/tektoncd/triggers@v0.25.0/pkg/client/injection/client/client.go:51:12: undefined: injection.Dynamic

go.mod:
	github.com/tektoncd/pipeline v0.50.1
	github.com/tektoncd/triggers v0.25.0
        knative.dev/pkg v0.0.0-20230718152110-aef227e72ead

could someone look at this, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants