Skip to content

fix: add JSON struct tags to fix TektonConfig status serialization #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tekton-robot merged 1 commit into from
Dec 31, 2025
Merged

fix: add JSON struct tags to fix TektonConfig status serialization #141

tekton-robot merged 1 commit into from
Dec 31, 2025

Conversation

@infernus01
Copy link
Member

@infernus01 infernus01 commented Dec 29, 2025

Changes

Adds JSON struct tags to pruner config structs to fix serialization issues when the configuration is reflected in TektonConfig CRD status.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 29, 2025
@infernus01
Copy link
Member Author

infernus01 commented Dec 29, 2025

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Dec 29, 2025
@infernus01
Copy link
Member Author

infernus01 commented Dec 29, 2025

/cc @pramodbindal

pramodbindal
pramodbindal reviewed Dec 31, 2025
View reviewed changes
@infernus01 infernus01 force-pushed the json-tag branch 2 times, most recently from ee1f9a7 to 896b8a8 Compare December 31, 2025 10:45
@infernus01
fix: add JSON struct tags to fix TektonConfig status serialization
e22cadb 
Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
@tekton-robot
Copy link

tekton-robot commented Dec 31, 2025

@openshift-konflux-bot: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pramodbindal
Copy link
Member

pramodbindal commented Dec 31, 2025

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 31, 2025
@pramodbindal
Copy link
Member

pramodbindal commented Dec 31, 2025

/approve

@tekton-robot
Copy link

tekton-robot commented Dec 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-konflux-bot, pramodbindal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 31, 2025
@tekton-robot tekton-robot merged commit 8feec18 into tektoncd:main Dec 31, 2025
21 checks passed
@anithapriyanatarajan
Copy link
Contributor

anithapriyanatarajan commented Jan 5, 2026

@infernus01 - could you cherry-pick to branch releasev-0.3.x

@infernus01
Copy link
Member Author

infernus01 commented Jan 5, 2026

/cherry-pick release-v0.3.x

1 similar comment
@anithapriyanatarajan
Copy link
Contributor

anithapriyanatarajan commented Jan 5, 2026

/cherry-pick release-v0.3.x

@tekton-robot
Copy link

tekton-robot commented Jan 5, 2026

✅ Cherry-pick to release-v0.3.x successful!

A new pull request has been created to cherry-pick this change to release-v0.3.x.

PR: #144

Please review and merge the cherry-pick PR.

@tekton-robot tekton-robot mentioned this pull request Jan 5, 2026
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pramodbindal pramodbindal pramodbindal left review comments

@anithapriyanatarajan anithapriyanatarajan Awaiting requested review from anithapriyanatarajan

@jkhelil jkhelil Awaiting requested review from jkhelil

+1 more reviewer

@openshift-konflux-bot openshift-konflux-bot openshift-konflux-bot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pramodbindal pramodbindal

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@infernus01 @tekton-robot @pramodbindal @anithapriyanatarajan @openshift-konflux-bot