Skip to content

[release-v1.3.x] check initContainers for kubernetes sidecar implementation #8997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2025
Merged

[release-v1.3.x] check initContainers for kubernetes sidecar implementation #8997

merged 1 commit into from
Sep 4, 2025

Conversation

@pritidesai
Copy link
Member

Changes

Manual Cherry-pick of #8986

The automated cherry-pick is not responding #8986 (comment)

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Updated the sidecar implementation to check the completion status of initContainers before marking the taskRun complete.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Aug 29, 2025
@tekton-robot tekton-robot requested review from abayer and jerop August 29, 2025 17:19
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 29, 2025
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/status.go 92.2% 92.4% 0.2

@pritidesai
Copy link
Member Author

/retest

1 similar comment
@pritidesai
Copy link
Member Author

/retest

waveywaves
waveywaves approved these changes Aug 29, 2025
View reviewed changes
Copy link
Member

@waveywaves waveywaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: waveywaves

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 29, 2025
@pritidesai
Copy link
Member Author

/retest

3 similar comments
@pritidesai
Copy link
Member Author

/retest

@pritidesai
Copy link
Member Author

/retest

@pritidesai
Copy link
Member Author

/retest

@pritidesai
Copy link
Member Author

This may not be a flake; I will review the errors thoroughly and address any potential issues.

@khrm
Copy link
Contributor

khrm commented Sep 1, 2025

@pritidesai I think there's some issue with e2e. It's failing for lot of PRs.

@pritidesai
Copy link
Member Author

/retest

@pritidesai
Copy link
Member Author

All five checks are failing with:

=== NAME  TestGitResolver_API_Identifier
    resolvers_test.go:545: Error waiting for gitea-0 pod to be running: timed out waiting for the condition
    panic.go:636: ############################################
    panic.go:636: ### Dumping objects from arendelle-tvzcz ###
    panic.go:636: ############################################
    panic.go:636: 
    panic.go:636: #####################################################
    panic.go:636: ### Dumping logs from Pods in the arendelle-tvzcz ###
    panic.go:636: #####################################################
    panic.go:636: Not deleting namespace arendelle-tvzcz
--- FAIL: TestGitResolver_API_Identifier (606.37s)
=== NAME  TestGitResolver_API
    resolvers_test.go:483: Error waiting for gitea-0 pod to be running: timed out waiting for the condition
    panic.go:636: ############################################
    panic.go:636: ### Dumping objects from arendelle-v6srb ###
    panic.go:636: ############################################
    panic.go:636: 
    panic.go:636: #####################################################
    panic.go:636: ### Dumping logs from Pods in the arendelle-v6srb ###
    panic.go:636: #####################################################
    panic.go:636: Not deleting namespace arendelle-v6srb
--- FAIL: TestGitResolver_API (606.48s)

@vdemeester
Copy link
Member

It is happening on several PR now. cc @khrm @waveywaves

@pritidesai
Copy link
Member Author

/retest

@pritidesai
check initContainers for kubernetes sidecar implementation
46da385 
This code checks if all containers in a Pod, including init containers, have
completed their execution before marking a TaskRun as complete when kubernetes
native sidecar is enabled. It's part of the TaskRun status determination logic.

Signed-off-by: Priti Desai <pdesai@us.ibm.com>
@pritidesai pritidesai merged commit f2d8d3d into tektoncd:release-v1.3.x Sep 4, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Tekton Community Roadmap Sep 4, 2025
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2025
@tekton-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/status.go 92.2% 92.4% 0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waveywaves waveywaves waveywaves approved these changes

@abayer abayer Awaiting requested review from abayer

@jerop jerop Awaiting requested review from jerop

Assignees

@waveywaves waveywaves

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

Tekton Community Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pritidesai @tekton-robot @khrm @vdemeester @waveywaves