Skip to content

[release-v1.1.x] fix(#8940): token-authentication header typo in git resolver #8946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[release-v1.1.x] fix(#8940): token-authentication header typo in git resolver #8946

wants to merge 2 commits into from

Conversation

@tekton-robot
Copy link
Collaborator

This is an automated cherry-pick of #8937

/assign waveywaves

Bug fix: Before this change, there was a regression in which the git resolver was not authenticating with the provided `gitToken` and `gitTokenKey`, breaking the git resolver's http token-based auth. After this change, all git operations performed by the git resolver use the provided `gitToken` for remote authentication.

aThorp96 added 2 commits August 5, 2025 11:29
@aThorp96
fix(tektoncd#8940): Fix token-authentication header in git resolver
394a0dd 
The header specified for the git resolver's http auth contained a typo
leading to authentication tokens not being properly sent to the remote.

Additionally, this change fixes the outdated token-authenticated git
resolver example and adds an e2e regression test for authenticated git
cloning.

Resolves: tektoncd#8940
Resolves: https://issues.redhat.com/browse/SRVKP-8260
@aThorp96
chore: fix unit test action name
82eccf3
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 5, 2025
@tekton-robot tekton-robot mentioned this pull request Aug 5, 2025
Merged
8 tasks
@tekton-robot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jeromeju after the PR has been reviewed.
You can assign the PR to them by writing /assign @jeromeju in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 5, 2025
@waveywaves
Copy link
Member

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 5, 2025
@waveywaves
Copy link
Member

/retest

@vdemeester
Copy link
Member

We don't need to cherry-pick to 1.1.x, it's not supported anymore.

@vdemeester vdemeester closed this Aug 5, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Tekton Community Roadmap Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pritidesai pritidesai Awaiting requested review from pritidesai

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@waveywaves waveywaves

Labels

kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Tekton Community Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tekton-robot @waveywaves @vdemeester @aThorp96