Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/taskrunmetrics/fake shouldn't be imported… #8184

Merged
merged 1 commit into from
Aug 7, 2024
Merged

pkg/taskrunmetrics/fake shouldn't be imported… #8184

merged 1 commit into from
Aug 7, 2024

Conversation

vdemeester
Copy link
Member

Changes

… in production code. It is used for unit-tests only. This might mess
up the injection code and which code is executed when for metrics.

Signed-off-by: Vincent Demeester vdemeest@redhat.com

/kind bug

Will probably need to be backported to LTS. This has been here for
ages…

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 6, 2024
@vdemeester
pkg/taskrunmetrics/fake shouldn't be imported…
50148c4 
… in production code. It is used for unit-tests only. This might mess
up the injection code and which code is executed when for metrics.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2024
@vdemeester vdemeester mentioned this pull request Aug 7, 2024
Merged
8 tasks
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024
@tekton-robot tekton-robot merged commit 74e1616 into tektoncd:main Aug 7, 2024
14 checks passed
@vdemeester vdemeester deleted the taskrunmetrics-fake-prod branch August 7, 2024 16:04
@vdemeester
Copy link
Member Author

/cherry-pick release-v0.62.x

@vdemeester
Copy link
Member Author

/cherry-pick release-v0.59.x

@vdemeester
Copy link
Member Author

/cherry-pick release-v0.56.x

@vdemeester
Copy link
Member Author

/cherry-pick release-v0.53.x

@tekton-robot
Copy link
Collaborator

@vdemeester: new pull request created: #8188

In response to this:

/cherry-pick release-v0.62.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Aug 7, 2024
Merged
@tekton-robot
Copy link
Collaborator

@vdemeester: new pull request created: #8189

In response to this:

/cherry-pick release-v0.59.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Aug 7, 2024
Merged
@tekton-robot
Copy link
Collaborator

@vdemeester: new pull request created: #8190

In response to this:

/cherry-pick release-v0.56.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Aug 7, 2024
Merged
Merged
@tekton-robot
Copy link
Collaborator

@vdemeester: new pull request created: #8191

In response to this:

/cherry-pick release-v0.53.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chitrangpatel chitrangpatel chitrangpatel approved these changes

@abayer abayer Awaiting requested review from abayer

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@piyush-garg piyush-garg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vdemeester @tekton-robot @piyush-garg @chitrangpatel