Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(taskrun): block taskrun spec updates once the taskrun has started #8147

Merged
merged 1 commit into from
Jul 25, 2024
Merged

fix(taskrun): block taskrun spec updates once the taskrun has started #8147

merged 1 commit into from
Jul 25, 2024

Conversation

l-qing
Copy link
Contributor

@l-qing l-qing commented Jul 24, 2024 •
edited
Loading

fix #8148

Typically, the spec field of a TaskRun resource is not allowed to be updated after creation, such as the timeout configuration.
Only a few fields, such as status statusMessage, are allowed to be updated.

Since the debug attribute affects the properties of containers within the pod, modifications are not permitted during runtime.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Fix: Once a TaskRun is created, most of the fields in the spec is not allowed to be updated; only status and statusMessage can be updated.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 24, 2024
@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 24, 2024
@tekton-robot
Copy link
Collaborator

Hi @l-qing. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@l-qing
Copy link
Contributor Author

l-qing commented Jul 24, 2024

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 24, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_validation.go 97.0% 96.7% -0.4
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.0% 96.7% -0.4

@l-qing l-qing force-pushed the fix/block-taskrun-spec-updates branch 2 times, most recently from c00a2b1 to 1fb6d74 Compare July 24, 2024 07:40
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_validation.go 97.0% 96.7% -0.4
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.0% 96.7% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_validation.go 97.0% 97.3% 0.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.0% 97.3% 0.3

@l-qing l-qing force-pushed the fix/block-taskrun-spec-updates branch from 1fb6d74 to 979b01f Compare July 24, 2024 08:27
@l-qing
fix(taskrun): block taskrun spec updates once the taskrun has started
342f77a 
fix tektoncd#8148

Typically, the spec field of a TaskRun resource is not allowed to be updated
after creation, such as the `timeout` configuration.
Only a few fields, such as `status` `statusMessage`, are allowed to be updated.
@l-qing l-qing force-pushed the fix/block-taskrun-spec-updates branch from 979b01f to 342f77a Compare July 24, 2024 08:28
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_validation.go 97.0% 97.4% 0.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.0% 97.4% 0.3

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_validation.go 97.0% 97.4% 0.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.0% 97.4% 0.3

@chitrangpatel
Copy link
Contributor

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 25, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_validation.go 97.0% 97.4% 0.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.0% 97.4% 0.3

afrittoli
afrittoli reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2024
@chitrangpatel
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2024
@tekton-robot tekton-robot merged commit d6a2cdb into tektoncd:main Jul 25, 2024
14 checks passed
@hrivera-ntap hrivera-ntap mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@abayer abayer Awaiting requested review from abayer

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@chitrangpatel chitrangpatel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The spec fields of TaskRun and PipelineRun can still be modified during execution
4 participants
@l-qing @tekton-robot @chitrangpatel @afrittoli