-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEP-0129] Move CRDs definition and update multi-tenancy docs accordingly #7598
Conversation
Move CRD files into the 300-crds folder to make it easier to not install CRDs in case of multi install into a single cluster. Since the release pipeline uses ko -R, this doesn't change anything for now in the release files. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
Update the multi-tenancy documentation to include all aspects of multi-tenancy and explain how to install the CRDs separately from the new dedicated folder. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update some scripts or docs with an -R
(recursive) ?
The |
/test pull-tekton-pipeline-alpha-integration-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👼🏼
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Changes
Move CRD files into the 300-crds folder to make it easier to not install CRDs in case of multi install into a single cluster.
Since the release pipeline uses
ko -R
, this doesn't change anything for now in the release files.Update the multi-tenancy documentation to include all aspects of multi-tenancy and explain how to install the CRDs separately from the new dedicated folder.
Signed-off-by: Andrea Frittoli andrea.frittoli@uk.ibm.com
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
/kind documentation