Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEP-0129] Move CRDs definition and update multi-tenancy docs accordingly #7598

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

afrittoli
Copy link
Member

Changes

Move CRD files into the 300-crds folder to make it easier to not install CRDs in case of multi install into a single cluster.
Since the release pipeline uses ko -R, this doesn't change anything for now in the release files.

Update the multi-tenancy documentation to include all aspects of multi-tenancy and explain how to install the CRDs separately from the new dedicated folder.

Signed-off-by: Andrea Frittoli andrea.frittoli@uk.ibm.com

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Document simple installation instructions for a Tekton multi-tenancy setup.

/kind documentation

@tekton-robot tekton-robot added kind/documentation Categorizes issue or PR as related to documentation. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 22, 2024
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 22, 2024
Move CRD files into the 300-crds folder to make it easier to
not install CRDs in case of multi install into a single cluster.

Since the release pipeline uses ko -R, this doesn't change
anything for now in the release files.

Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
Update the multi-tenancy documentation to include all aspects
of multi-tenancy and explain how to install the CRDs separately
from the new dedicated folder.

Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 22, 2024
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update some scripts or docs with an -R (recursive) ?

@afrittoli afrittoli closed this Feb 12, 2024
@afrittoli afrittoli reopened this Feb 12, 2024
@afrittoli
Copy link
Member Author

Do we need to update some scripts or docs with an -R (recursive) ?

The -R is already needed because of the namespace, but I'll doublecheck to be sure

@afrittoli afrittoli closed this Feb 26, 2024
@afrittoli afrittoli reopened this Feb 26, 2024
@afrittoli
Copy link
Member Author

/test pull-tekton-pipeline-alpha-integration-tests

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼🏼

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@afrittoli
Copy link
Member Author

@dibyom would you be interested in reviewing this, since you reviewed #923 previously?

@chitrangpatel
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2024
@tekton-robot tekton-robot merged commit 6863dd4 into tektoncd:main Mar 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants