TEP-0114: Stop serving v1beta1.CustomRun until we align on Retries

[jerop]

Changes

In this change, we stop serving the v1beta1.CustomRun CRD. This is because we are still discussing how to handle Retries in CustomRuns.

Related TEPs:

• TEP-0114: Custom Tasks Beta
• TEP-0121: Retries

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs included if any changes are user facing
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[jerop]

/kind cleanup

[jerop]

/test check-pr-has-kind-label

[tekton-robot]

@jerop: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test pull-tekton-pipeline-alpha-integration-tests
• /test pull-tekton-pipeline-build-tests
• /test pull-tekton-pipeline-integration-tests
• /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

• /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jerop]

/hold

need to fix the e2e tests

[abayer]

/retest

Those failures don't make much sense at first glance - seems worth a rerun.

[abayer]

@jerop I spun up a cluster locally with this change, and while I didn't get the error here, the controller had this in its logs:

W1109 18:36:14.763454       1 reflector.go:424] k8s.io/client-go@v0.25.3/tools/cache/reflector.go:169: failed to list *v1beta1.CustomRun: the server could not find the requested resource (get customruns.tekton.dev)
E1109 18:36:14.766094       1 reflector.go:140] k8s.io/client-go@v0.25.3/tools/cache/reflector.go:169: Failed to watch *v1beta1.CustomRun: failed to list *v1beta1.CustomRun: the server could not find the requested resource (get customruns.tekton.dev)

(and other issues in the webhook)

We've gotta remove the customrun.NewController() reference from cmd/controller/main.go, and v1beta1.SchemeGroupVersion.WithKind("CustomRun"): &v1beta1.CustomRun{} from cmd/webhook/main.go to turn off serving for v1beta1.CustomRun. Once I did that, things worked.

[jerop]

/hold cancel

e2e test fixed, many thanks to @abayer!

[abayer]

/lgtm