Remove logging.request-log-template from resolvers config-observability CM #5717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty CM Fixes tektoncd#5707 When I copied `config/resolvers/config-observability.yaml` from resolution.git, I didn't notice that, unlike our existing `config/config-observability.yaml`, it contained a rather elaborate `logging.request-log-template` example. That example ends up causing problems with Helm, due to it containing syntax that Helm tries to resolve, like `{{.Request.Method}}`. There's no real reason to have that example there, and we don't have it in the `tekton-pipelines` namespace's `config-observability`, so I'm removing it from `config/resolvers/config-observability.yaml` now. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
tekton-robot
added
the
release-note
tekton-robot
added
the
size/S
vdemeester
approved these changes
Nov 4, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
dibyom
added
the
needs-cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #5707
When I copied
config/resolvers/config-observability.yamlfrom resolution.git, I didn't notice that, unlike our existingconfig/config-observability.yaml, it contained a rather elaboratelogging.request-log-templateexample. That example ends up causing problems with Helm, due to it containing syntax that Helm tries to resolve, like{{.Request.Method}}.There's no real reason to have that example there, and we don't have it in the
tekton-pipelinesnamespace'sconfig-observability, so I'm removing it fromconfig/resolvers/config-observability.yamlnow./kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes