Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PipelineRun and TaskRun Status work to the Roadmap #3793

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

jerop
Copy link
Member

@jerop jerop commented Feb 25, 2021

Changes

Adding redesign of PipelineRun and TaskRun Status as a priority in the
2021 roadmap as we work towards V1

/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [n/a] Includes tests (if functionality changed/added)
  • [n/a] Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

/cc @bobcatfish

Adding redesign of PipelineRun and TaskRun Status as a priority in the
2021 roadmap as we work towards V1

tektoncd#3792
@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 25, 2021
@bobcatfish
Copy link
Collaborator

sounds good to me!

/approve

would love to hear from another owner as well before we merge @tektoncd/core-maintainers

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2021
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2021
@ghost
Copy link

ghost commented Feb 25, 2021

Revisiting status as a whole sounds like a good idea to me.

/lgtm

@tekton-robot tekton-robot assigned ghost Feb 25, 2021
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2021
@pritidesai
Copy link
Member

yup, will be great to revisit both taskrun and pipelinerun status 👍

/lgtm

@jerop
Copy link
Member Author

jerop commented Mar 4, 2021

thanks for the reviews @bobcatfish @sbwsg @pritidesai 🙏🏾

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2021
@tekton-robot tekton-robot merged commit ae90afd into tektoncd:master Mar 4, 2021
@jerop jerop deleted the status branch June 11, 2022 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants