Skip to content

Commit

Permalink
Change the webhook name to pipeline-webhook
Browse files Browse the repository at this point in the history
The "webhook" name is too generic and it creates conflicts on leases
when other services (like triggers) that use leader election run in
same namespace but with different configuration.

Fixes #3529

Co-authored-by: Matt Moore <mattmoor@vmware.com>

Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
  • Loading branch information
afrittoli authored and tekton-robot committed Nov 17, 2020
1 parent ed15c94 commit 747f4ba
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion cmd/webhook/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,10 @@ func main() {
log.Fatal(http.ListenAndServe(":"+port, mux))
}()

sharedmain.WebhookMainWithConfig(ctx, "webhook",
// NOTE(afrittoli) - we should have the name "webhook-pipeline"
// configurable. Once the change is done on knative/pkg side
// knative/eventing#4530 we can inherit it from it
sharedmain.WebhookMainWithConfig(ctx, "webhook-pipeline",
sharedmain.ParseAndGetConfigOrDie(),
certificates.NewController,
newDefaultingAdmissionController,
Expand Down

0 comments on commit 747f4ba

Please sign in to comment.