Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create PAC pipelinerun templates for console to access #857

Merged
merged 3 commits into from
Jun 27, 2022
Merged

Create PAC pipelinerun templates for console to access #857

merged 3 commits into from
Jun 27, 2022

Conversation

sm43
Copy link
Member

@sm43 sm43 commented Jun 23, 2022 •
edited
Loading

this fetches the pr templates while fetching release yaml and keep in ko data
later it creates configmaps with pipelinerun templates and add in installer set
console will use this templates.
also adds rbac to access templates for non admin users

Signed-off-by: Shivam Mukhade smukhade@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Create PAC pipelinerun templates for console to access
ead726f 
Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 23, 2022
@sm43 sm43 requested a review from vdemeester June 23, 2022 05:29
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 23, 2022
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/pipelinesascode.go 0.0% 28.1% 28.1

vdemeester
vdemeester reviewed Jun 23, 2022
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, one question though.

hack/fetch-releases.sh Outdated Show resolved Hide resolved
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/pipelinesascode.go 0.0% 28.8% 28.8

Adds rbac for accessing pipelines as code templates by non-admin users
755d272 
Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@sm43 sm43 force-pushed the pac-pr-templates branch from 8a00db9 to 755d272 Compare June 24, 2022 08:24
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/pipelinesascode.go 0.0% 28.8% 28.8

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jun 24, 2022
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/pipelinesascode.go 0.0% 15.6% 15.6

concaf
concaf reviewed Jun 24, 2022
View reviewed changes
hack/fetch-releases.sh Outdated
Comment on lines 131 to 137
source="https://raw.githubusercontent.com/openshift-pipelines/pipelines-as-code/main/pkg/cmd/tknpac/generate/templates/${run}-template.yaml"
dest_dir="${ko_data}/tekton-addon/pipelines-as-code-templates"
mkdir -p ${dest_dir} || true
destination="${dest_dir}/${run}-template.yaml"

http_response=$(curl -s -o ${destination} -w "%{http_code}" ${source})
echo url: ${source}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird indentation here 🤔

@sm43
Copy link
Member Author

sm43 commented Jun 24, 2022

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2022
@sm43 sm43 force-pushed the pac-pr-templates branch from ef267ce to 80850ed Compare June 24, 2022 12:44
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/pipelinesascode.go 0.0% 15.6% 15.6

PAC: Update info configmap with controller route
c4dbd2a 
Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@sm43 sm43 force-pushed the pac-pr-templates branch from 80850ed to c4dbd2a Compare June 24, 2022 12:50
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonaddon/pipelinesascode.go 0.0% 15.6% 15.6

@sm43 sm43 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2022
@sm43
Copy link
Member Author

sm43 commented Jun 24, 2022

/retest

@pradeepitm12
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2022
@piyush-garg
Copy link
Contributor

we missed the license header in files

@tekton-robot tekton-robot merged commit 991612a into tektoncd:main Jun 27, 2022
@sm43 sm43 deleted the pac-pr-templates branch June 27, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-garg piyush-garg piyush-garg left review comments

@concaf concaf concaf left review comments

@vdemeester vdemeester vdemeester approved these changes

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

Assignees

@piyush-garg piyush-garg

@pradeepitm12 pradeepitm12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sm43 @tekton-robot @piyush-garg @pradeepitm12 @vdemeester @concaf