fix pac settings map pointer reconciliation Loop

[jkhelil]

Changes

• Every reconciliation loop unconditionally reassigned the Settings map
• Even if values were identical, the map's memory pointer changed
• Kubernetes detected the pointer change as a modification
• This triggered resourceVersion increment on CR update
• Led to continuous reconciliation even when no real changes occurred

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Run make test lint before submitting a PR
• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

NONE

[jkhelil]

/kind bug

[mbpavan]

/approve

[mbpavan]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbpavan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mbpavan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment