Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support addition of new containers provided as options #2557

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

enarha
Copy link
Contributor

@enarha enarha commented Feb 9, 2025

If a container or initContainer is provided in options of deployment or statefulset, if a container or initContainer with that name exists, the properties for of that container will be updated with the values provided in options.
With that change, if there is no match, the container or initContainer from options will be added to the deployments and statefulsets.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Existing TektonConfig manifests, with additional options for deployments and statefulSets
and including new containers and initContainers, those containers and initContainers will
now be added to the deployments and statefulSets. Previously new containers and 
initContainers were ignored and only existing containers and initContainers were updated
with the configuration added as additional options.

If a container or initContainer is provided in options of deployment or
statefulset, if a container or initContainer with that name exists,
the properties for of that container will be updated with the values
provided in options.
With that change, if there is no match, the container or initContainer
from options will be added to the deployments and statefulsets.
@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 9, 2025
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 9, 2025
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/transformer_additional_options.go 87.2% 87.5% 0.2

@jkhelil
Copy link
Member

jkhelil commented Feb 10, 2025

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkhelil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2025
@pratap0007
Copy link
Contributor

LGTM

@jkhelil
Copy link
Member

jkhelil commented Feb 11, 2025

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2025
@tekton-robot tekton-robot merged commit 97b76ef into tektoncd:main Feb 11, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants