Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update triggers default configmap for FSGroup to handle restricted securityContext for Triggers #2285

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

savitaashture
Copy link
Contributor

@savitaashture savitaashture commented Aug 19, 2024

as part of this PR tektoncd/triggers#1740 we've introduced an FSGroup setting to comply with restricted pod security standards for the podTemplate.
But the default value 65532 won't work on OpenShift so setting "" by default for FSGroup

Remaining part of the work is done here #2125

Signed-off-by: Savita Ashture sashture@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

…curityContext for Triggers

as part of this PR tektoncd/triggers#1740 we've introduced an FSGroup setting to comply with restricted pod security standards for the podTemplate.
But the default value 65532 won't work on OpenShift so setting  by default for FSGroup

Signed-off-by: Savita Ashture <sashture@redhat.com>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 19, 2024
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 19, 2024
@savitaashture savitaashture requested a review from jkandasa August 19, 2024 08:26
Copy link
Member

@jkandasa jkandasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2024
@tekton-robot tekton-robot merged commit a38810f into tektoncd:main Aug 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants