Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Adds store for resources using mobx-state-tree #70

Merged
merged 1 commit into from
Nov 17, 2020
Merged

UI: Adds store for resources using mobx-state-tree #70

merged 1 commit into from
Nov 17, 2020

Conversation

pratap0007
Copy link
Contributor

Signed-off-by: Shiv verma shverma@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2020
@tekton-robot tekton-robot requested review from sm43 and sthaha August 19, 2020 02:59
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 19, 2020
@pratap0007 pratap0007 force-pushed the resources-store branch 2 times, most recently from 66ba470 to 9935772 Compare August 24, 2020 04:05
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2020
@pratap0007 pratap0007 force-pushed the resources-store branch 4 times, most recently from 0c00aa6 to 24a2b4a Compare September 3, 2020 06:23
@pratap0007 pratap0007 force-pushed the resources-store branch 2 times, most recently from cbf30fe to 334bc67 Compare September 14, 2020 02:37
@pratap0007 pratap0007 changed the title [WIP] UI: Adds MST store for resource information Adds store for resources using mobx-state-tree Sep 14, 2020
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2020
PuneetPunamiya
PuneetPunamiya reviewed Sep 14, 2020
View reviewed changes
ui/src/App.tsx Outdated Show resolved Hide resolved
PuneetPunamiya
PuneetPunamiya reviewed Sep 14, 2020
View reviewed changes
ui/src/api/index.ts Outdated Show resolved Hide resolved
vinamra28
vinamra28 reviewed Sep 14, 2020
View reviewed changes
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: just a few suggestions

ui/src/store/catalog.ts Outdated Show resolved Hide resolved
ui/src/store/category.ts Outdated Show resolved Hide resolved
ui/src/store/kind.ts Outdated Show resolved Hide resolved
ui/src/store/resources.ts Outdated Show resolved Hide resolved
ui/src/store/resources.ts Outdated Show resolved Hide resolved
vinamra28
vinamra28 reviewed Sep 14, 2020
View reviewed changes
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit 😅

ui/src/index.tsx Outdated Show resolved Hide resolved
sthaha
sthaha reviewed Sep 15, 2020
View reviewed changes
ui/src/api/testutil.ts Outdated Show resolved Hide resolved
sthaha
sthaha reviewed Sep 15, 2020
View reviewed changes
ui/src/store/catalog.ts Outdated Show resolved Hide resolved
@pratap0007 pratap0007 force-pushed the resources-store branch 2 times, most recently from 8690861 to 64fc291 Compare September 16, 2020 01:45
vinamra28
vinamra28 reviewed Sep 16, 2020
View reviewed changes
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one last comment otherwise looks good to me

ui/src/api/testutil.ts Outdated Show resolved Hide resolved
@sm43 sm43 changed the title Adds store for resources using mobx-state-tree UI: Adds store for resources using mobx-state-tree Sep 16, 2020
@pratap0007 pratap0007 force-pushed the resources-store branch 2 times, most recently from a1e4cac to 2ae5503 Compare October 27, 2020 11:13
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 10, 2020
@PuneetPunamiya
Copy link
Member

/retest

@pratap0007 pratap0007 force-pushed the resources-store branch 6 times, most recently from 56ee240 to 35b1b5b Compare November 16, 2020 04:36
@PuneetPunamiya
Adds resources store using mst
aadb130 
  This patch includes:
     - adds a kind, catalog, resource and root store
     - updates category store
     - minor changes in Filter component

Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 16, 2020
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 16, 2020
@pratap0007
Copy link
Contributor Author

/lgtm
/approve

@tekton-robot
Copy link

@pratap0007: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2020
@PuneetPunamiya
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2020
@PuneetPunamiya
Copy link
Member

/approve
/meow

@tekton-robot
Copy link

@PuneetPunamiya: cat image

In response to this:

/approve
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pratap0007, PuneetPunamiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [PuneetPunamiya,pratap0007]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 8ef78ba into tektoncd:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PuneetPunamiya PuneetPunamiya PuneetPunamiya left review comments

@vinamra28 vinamra28 vinamra28 left review comments

@sthaha sthaha sthaha left review comments

@sm43 sm43 Awaiting requested review from sm43

Assignees

@PuneetPunamiya PuneetPunamiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pratap0007 @PuneetPunamiya @tekton-robot @sthaha @vinamra28