Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes hub preview APIs for resources #386

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

PuneetPunamiya
Copy link
Member

When we announced v1 APIs for resources in Jan 2020, we also
said we are deprecating and would support the preview APIs
for atleast 9 months as per the API policy.
https://github.com/tektoncd/hub/blob/main/docs/API_POLICY.md
Now, that we have completed a year we can safe to remove preview
APIs.

Signed-off-by: Puneet Punamiya ppunamiy@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run API Unit Tests, Lint Checks, API Design, Golden Files with make api-check
  • Run UI Unit Tests, Lint Checks with make ui-check
  • Commit messages follow commit message best practices

See the contribution guide for more details.

@tekton-robot tekton-robot requested review from sm43 and vdemeester March 1, 2022 13:19
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 1, 2022
@sm43
Copy link
Member

sm43 commented Mar 2, 2022

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sm43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2022
@sm43
Copy link
Member

sm43 commented Mar 2, 2022

/meow

@tekton-robot
Copy link

@sm43: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pratap0007
Copy link
Contributor

lgtm

@PuneetPunamiya
Copy link
Member Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2022
When we announced v1 APIs for resources in Jan 2020, we also
said we are deprecating and would support the preview APIs
for atleast 9 months as per the API policy.
https://github.com/tektoncd/hub/blob/main/docs/API_POLICY.md
Now, that we have completed a year we can safe to remove preview
APIs.

Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>
@PuneetPunamiya
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2022
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2022
@tekton-robot tekton-robot merged commit 85c290a into tektoncd:main Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants