Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give Vinamra & Piyush Hub scopes #331

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Give Vinamra & Piyush Hub scopes #331

merged 1 commit into from
Oct 25, 2021

Conversation

vinamra28
Copy link
Member

Changes

Add @vinamra28 and @piyush-garg in config.yaml to give additional hub scopes
such as config-refresh, catalog-refresh and agent-create.

Signed-off-by: vinamra28 vinjain@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run API Unit Tests, Lint Checks, API Design, Golden Files with make api-check
  • Run UI Unit Tests, Lint Checks with make ui-check
  • Commit messages follow commit message best practices

See the contribution guide for more details.

@vinamra28
Give Vinamra & Piyush Hub scopes
70d5608 
Signed-off-by: vinamra28 <vinjain@redhat.com>
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 21, 2021
@sm43
Copy link
Member

sm43 commented Oct 25, 2021

/lgtm
/approve

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sm43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2021
@tekton-robot tekton-robot merged commit 199d5a2 into tektoncd:main Oct 25, 2021
@vinamra28 vinamra28 deleted the add-vinamra-and-piyush-in-config branch October 25, 2021 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

@sm43 sm43 Awaiting requested review from sm43

Assignees

@sm43 sm43

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinamra28 @sm43 @tekton-robot