Return err if db-migration fails #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/L
docs/DEPLOYMENT.md
Outdated
| @@ -122,23 +126,26 @@ db-migration-8vhpd 0/1 Completed 0 17s | |||
|
|
|||
| You can also check the logs using `kubectl logs -n tekton-hub db-migration-8vhpd` | |||
There was a problem hiding this comment.
I think we can delete this line now
vinamra28
force-pushed
the
deployment-cleanup
branch
from
e8d2878 to
8cf3867
Compare
vinamra28
commented
Sep 6, 2021
| $ kubectl get pods -n tekton-hub | ||
| NAME READY STATUS RESTARTS AGE | ||
| db-589d44fdd5-ksf8v 1/1 Running 0 50s | ||
| db-migration-8vhpd 0/1 Error 0 17s |
There was a problem hiding this comment.
I guess it's already there. Ref: https://github.com/tektoncd/hub/pull/318/files#diff-ea9864292e6e392d0c8edbabfe41014d61d6ebd2e08f34d8ae21bf9d070fb274L120
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PuneetPunamiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Earlier db-migration does not returns with error code if it fails and thus we had to check the logs for the failure. With this PR if the migration fails it will return an exit code and thus the job will fail. Also updated the Deployment docs and also fixed some formatting of the docs. Signed-off-by: vinamra28 <vinjain@redhat.com>
vinamra28
force-pushed
the
deployment-cleanup
branch
from
8cf3867 to
307a75f
Compare
|
lgtm |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Earlier db-migration does not returns with error code if it fails and thus
we had to check the logs for the failure. With this PR if the migration
fails it will return an exit code and thus the job will fail.
Also updated the Deployment docs and also fixed some formatting of the
docs.
Signed-off-by: vinamra28 vinjain@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make api-checkmake ui-checkSee the contribution guide for more details.